All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: [Patch] ioemu-remote: fix gcc4 build problem (?)
Date: Sun, 20 Jul 2008 15:29:07 +0200	[thread overview]
Message-ID: <48833DA3.4060202@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

Ian,

although I read that the gcc4 build problem should already be fixed, I 
cannot ack this for me: I just did
$ git clone http://xenbits.xensource.com/git-http/qemu-xen-unstable.git 
and "$ hg pull -u" in xen-staging and still configure stops with missing 
gcc3. In ioemu-remote "git log" says the latest patch was:
----------
commit 1ec7aa3263bc7fd78bcc40e4ceb2ca067a1a8687
Author: Ian Jackson <iwj@mariner.uk.xensource.com>
Date:   Mon Jul 14 13:46:28 2008 +0100
     qemu ioemu rendering fixes for palette handling (another dropped patch)
.....
----------

If a fix is already submitted, it would be nice if someone could point 
me how keep my tree up-to-date.

Anyway now my version of the patch:
AFAIK the qemu gcc3 build restriction does not apply to ioemu, in the 
old embedded tree "check_gcc" was set to "no" per default in 
tools/ioemu/configure. Either we do the same in the ioemu-remote tree or 
use the below patch to fix the shell test error (already in qemu since 
May 23rd: 
http://lists.gnu.org/archive/html/qemu-devel/2008-05/msg00875.html) and 
call configure with --disable-gcc-check (which is closer to the upstream 
qemu tree).

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
Original QEMU patch by Paul Brook

Regards,
Andre.

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

[-- Attachment #2: qemu-xen-gcc-check.patch --]
[-- Type: text/plain, Size: 853 bytes --]

diff --git a/configure b/configure
index 2366aa6..30bab12 100755
--- a/configure
+++ b/configure
@@ -1241,7 +1241,7 @@ case "$target_cpu" in
     fi
     echo "#define CONFIG_DYNGEN_OP 1" >> $config_h
     gcc3minver=`$cc --version 2> /dev/null| fgrep "(GCC) 3." | awk '{ print $3 }' | cut -f2 -d.`
-    if test -n "$gcc3minver" -a $gcc3minver -gt 3
+    if test -n "$gcc3minver" && test $gcc3minver -gt 3
     then
       echo "HAVE_GT_GCC_3_3=true" >> $config_mak
     else
diff --git a/xen-setup b/xen-setup
index 755b9ec..b0eda89 100755
--- a/xen-setup
+++ b/xen-setup
@@ -9,7 +9,7 @@ rm -f config-host.mak
 
 if test -f config-host.h; then mv config-host.h config-host.h~; fi
 
-./configure --disable-curses --disable-slirp "$@" --prefix=/usr
+./configure --disable-gcc-check --disable-curses --disable-slirp "$@" --prefix=/usr
 
 target=i386-dm
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2008-07-20 13:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-20 13:29 Andre Przywara [this message]
2008-07-21 10:58 ` [Patch] ioemu-remote: fix gcc4 build problem (?) Ian Jackson
2008-07-21 10:59   ` Ian Jackson
2008-07-21 11:35   ` Andre Przywara
2008-07-21 13:10     ` Ian Jackson
2008-07-21 15:41       ` Andre Przywara
2008-07-22 15:30         ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48833DA3.4060202@amd.com \
    --to=andre.przywara@amd.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.