From: Timur Tabi <timur@freescale.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] ALSA: soc - fsl_ssi.c fix audio capture
Date: Mon, 21 Jul 2008 09:56:17 -0500 [thread overview]
Message-ID: <4884A391.7010500@freescale.com> (raw)
In-Reply-To: <20080704154346.GA27136@polina.dev.rtsoft.ru>
Anton Vorontsov wrote:
> Since we're using SSI in synchronous mode, the STCCR register controls
> both the receive and transmit sections. So, when we're trying to record
> anything, stccr register does not get initialized, thus the output file
> filled with the white noise.
>
> Fix this by initializing the STCCR for both playback and capture.
>
> Also use hw_params and hw_free callbacks, so that we won't fail at the
> last moment, thus applications could negotiate.
I already have a patch that fixes this problem, I'm just not ready to post it.
I really do appreciate your efforts, Anton, but you have to give me a chance to
do my job!
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-07-21 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 14:37 [PATCH] ALSA: soc - fsl_ssi.c fix audio capture Anton Vorontsov
2008-07-03 14:42 ` Mark Brown
2008-07-04 11:02 ` Timur Tabi
2008-07-04 11:01 ` Mark Brown
2008-07-04 11:08 ` Timur Tabi
2008-07-04 14:49 ` Takashi Iwai
2008-07-04 15:43 ` Anton Vorontsov
2008-07-04 15:43 ` [PATCH 1/2] " Anton Vorontsov
2008-07-21 14:56 ` Timur Tabi [this message]
2008-07-04 15:44 ` [PATCH 2/2] ALSA: soc - cs4270: fix ADC/DAC rate matching Anton Vorontsov
2008-07-21 14:54 ` Timur Tabi
2008-07-21 11:15 ` [PATCH] ALSA: soc - fsl_ssi.c fix audio capture Anton Vorontsov
2008-07-21 14:35 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884A391.7010500@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=avorontsov@ru.mvista.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.