From: Timur Tabi <timur@freescale.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: ALSA-devel <alsa-devel@alsa-project.org>
Subject: Re: CS4279 and hw_read_t/hw_write_t
Date: Mon, 21 Jul 2008 10:07:45 -0500 [thread overview]
Message-ID: <4884A641.80304@freescale.com> (raw)
In-Reply-To: <9e4733910807210806v4caf49f1ke90cefda07b63579@mail.gmail.com>
Jon Smirl wrote:
> From soc/codecs/cs4270.c...
>
> *
> * Note that we don't use the hw_write function pointer of snd_soc_codec.
> * That's because it's too clunky: the hw_write_t prototype does not match
> * i2c_smbus_write_byte_data(), and it's just another layer of overhead.
> */
>
> The prototype doesn't match because you are using
> i2c_smbus_write_byte_data() instead of
> i2c_master_send()/i2c_master_recv().
Should I be using i2c_master_send() instead? I remember reading somewhere that
I should be using the i2c smbus functions if possible.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-07-21 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 15:06 CS4279 and hw_read_t/hw_write_t Jon Smirl
2008-07-21 15:07 ` Timur Tabi [this message]
2008-07-21 15:16 ` Jon Smirl
2008-07-21 15:18 ` Timur Tabi
2008-07-21 15:25 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884A641.80304@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.