From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Christian Limpach <Christian.Limpach@xensource.com>,
Jens Axboe <jens.axboe@oracle.com>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] xen-blkfront.c: make blkif_ioctl() static
Date: Mon, 21 Jul 2008 14:03:32 -0700 [thread overview]
Message-ID: <4884F9A4.8060201@goop.org> (raw)
In-Reply-To: <20080721193339.GC14846@cs181140183.pp.htv.fi>
Adrian Bunk wrote:
> This patch makes the needlessly global blkif_ioctl() static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> c3e35790145bb28443ccb672fb46318e845c5f05
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9ae05c5..3ca643c 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -154,8 +154,8 @@ static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> return 0;
> }
>
> -int blkif_ioctl(struct inode *inode, struct file *filep,
> - unsigned command, unsigned long argument)
> +static int blkif_ioctl(struct inode *inode, struct file *filep,
> + unsigned command, unsigned long argument)
> {
> struct blkfront_info *info =
> inode->i_bdev->bd_disk->private_data;
>
>
next prev parent reply other threads:[~2008-07-21 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 19:33 [2.6 patch] xen-blkfront.c: make blkif_ioctl() static Adrian Bunk
2008-07-21 21:03 ` Jeremy Fitzhardinge [this message]
2008-08-04 10:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884F9A4.8060201@goop.org \
--to=jeremy@goop.org \
--cc=Christian.Limpach@xensource.com \
--cc=bunk@kernel.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.