From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7770C25B78 for ; Mon, 20 May 2024 21:34:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0CAC085D; Mon, 20 May 2024 23:33:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0CAC085D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1716240847; bh=WrZ5Vf7Jh3/G3dGoiHMd/08geH9pMlfqTaIaOal5dMk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=aGcTdRTl1hzW60XXMJK4vLK6Yu3101W03x0Cu5rq4k6Hrp1rfOBWkcKPppnApCBG1 3bSon/NlAQOzcDolWhVT6oGeGScqU6tiyhG4XXnfnp5JXVcyu0yhLmDH2SMIY/PDfn 9ReL3rODbY1uJ1N/Z8F55OWh3HQpdHKYEjPwZmjE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6580BF8057A; Mon, 20 May 2024 23:33:35 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D91B0F80579; Mon, 20 May 2024 23:33:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ECEC8F8026A; Mon, 20 May 2024 23:33:29 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 92A42F801F5 for ; Mon, 20 May 2024 23:33:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 92A42F801F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=XBp1liKj DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716240804; x=1747776804; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=WrZ5Vf7Jh3/G3dGoiHMd/08geH9pMlfqTaIaOal5dMk=; b=XBp1liKjP/IPxnOv7nzgij451Zj1xKj9rvzbgQcJ9+o2vuvCK7uAG3T3 KsS6UF5YHol0s7ZeHpaqiEXptXpIwMBeJn+fg6UMilmFctaDy+wax/aCw MqeCW44nm803gXThBKUqUukR5GETanwju0jY8PzfEknSXUhI+RWg1WnYc meRTM++s/HKDgdngApgLyO1pcxnQ5H/aF3Ying8DSek8ocI909uq2BrpT VFsGq8EAkfx4DIeLhhpF+2gtWr7ST6fOP1llV/IRySXl1C7ZebjhgvEtv w4PJ28WmBlQKdqscukiCxAlc+tqR+o+16EE+szpsERExPhlktBKyDA1AY g==; X-CSE-ConnectionGUID: RBiOJbAgTRa1DzeuMKJapQ== X-CSE-MsgGUID: CsxMcY5VR26oOoU/GyqrTw== X-IronPort-AV: E=McAfee;i="6600,9927,11078"; a="29922093" X-IronPort-AV: E=Sophos;i="6.08,176,1712646000"; d="scan'208";a="29922093" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 14:33:19 -0700 X-CSE-ConnectionGUID: u4AE7DrRRte9dwLdiod1Kg== X-CSE-MsgGUID: K2cU40uRQLSWHZ62riEPiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,176,1712646000"; d="scan'208";a="32552694" Received: from daliomra-mobl3.amr.corp.intel.com (HELO [10.125.109.51]) ([10.125.109.51]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 14:33:19 -0700 Message-ID: <4884ef78-2b86-4dcd-bec4-d6e111fa5455@linux.intel.com> Date: Mon, 20 May 2024 16:33:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ASoC: intel: Constify struct snd_soc_ops To: Christophe JAILLET , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org References: <2f0613bf4c6018569cdaac876d0589e49cf38a80.1715622793.git.christophe.jaillet@wanadoo.fr> Content-Language: en-US From: Pierre-Louis Bossart In-Reply-To: <2f0613bf4c6018569cdaac876d0589e49cf38a80.1715622793.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: 6ZG7PBDPPVMLJZGO2DIF2BI4VUGICKYY X-Message-ID-Hash: 6ZG7PBDPPVMLJZGO2DIF2BI4VUGICKYY X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/13/24 12:57, Christophe JAILLET wrote: > Constifying "struct snd_soc_ops" moves some data to a read-only section, so > increase overall security. > > This structure is also part of scripts/const_structs.checkpatch. > > As an example, on a x86_64, with allmodconfig: > Before: > text data bss dec hex filename > 6315 3696 0 10011 271b sound/soc/intel/boards/ehl_rt5660.o > > After: > text data bss dec hex filename > 6379 3648 0 10027 272b sound/soc/intel/boards/ehl_rt5660.o > > Signed-off-by: Christophe JAILLET > --- > Compile tested only. We don't test all the boards in CI but I don't see any issues with https://github.com/thesofproject/linux/pull/4993, so Tested-by: Pierre-Louis Bossart