Patrick McHardy wrote: > Patrick McHardy wrote: >> David Miller wrote: >>> Maybe something like the following should do it? >> >> >> It looks correct in any case. I'm not sure whether it fixes >> this lockdep warning though, according to the backtrace and >> module list its b43 and dev_mc_sync in net/mac80211/main.c >> that are causing the error, which don't seem to be included >> in your patch. I'm unable to find where it previously >> initialized the xmit_lock lockdep class though, so I must >> be missing something :) > > This is what I was missing, we're setting a lockdep class > by default depending on dev->type. This patch combined > with yours should fix all addr_list_lock warnings. This one is a bit nicer, since we only have a single addr_list_lock we don't need to pass a pointer to the lock.