From: roel kluin <roel.kluin@gmail.com>
To: mingo@elte.hu, rml@tech9.net, a.p.zijlstra@chello.nl
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period
Date: Mon, 21 Jul 2008 20:28:34 -0400 [thread overview]
Message-ID: <488529B2.1080609@gmail.com> (raw)
Peter, you added the test in global_rt_runtime(), in commit
d0b27fa77854b149ad4af08b0fe47fe712a47ade
could you take a look at it and tell whether this test should
be replaced by something else?
The patch was only checkpatch tested
---
sysctl_sched_rt_period is unsigned so the test doesn't work.
state_filter is an unsigned long so the test didn't work
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 99e6d85..2030340 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -832,9 +832,6 @@ static inline u64 global_rt_period(void)
static inline u64 global_rt_runtime(void)
{
- if (sysctl_sched_rt_period < 0)
- return RUNTIME_INF;
-
return (u64)sysctl_sched_rt_runtime * NSEC_PER_USEC;
}
@@ -5707,7 +5704,7 @@ void show_state_filter(unsigned long state_filter)
/*
* Only show locks if all tasks are dumped:
*/
- if (state_filter == -1)
+ if (state_filter == -1ul)
debug_show_all_locks();
}
next reply other threads:[~2008-07-22 0:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 0:28 roel kluin [this message]
2008-07-22 9:08 ` [PATCH 1/9] sched: test below 0 on unsigned sysctl_sched_rt_period Peter Zijlstra
2008-07-22 20:51 ` [PATCH] sched: Test runtime rather than period in global_rt_runtime() roel kluin
2008-07-23 6:25 ` Peter Zijlstra
2008-07-28 14:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488529B2.1080609@gmail.com \
--to=roel.kluin@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.