From: Philip Langdale <philipl@overt.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
toshiba_acpi@memebeam.org, randy.dunlap@oracle.com
Subject: Re: [PATCH] toshiba_acpi: Add support for bluetooth toggling through rfkill
Date: Mon, 21 Jul 2008 21:20:11 -0700 [thread overview]
Message-ID: <48855FFB.40808@overt.org> (raw)
In-Reply-To: <20080720135239.GA14801@khazad-dum.debian.net>
Henrique de Moraes Holschuh wrote:
> Please consider updating your patch to the new style rfkill class. A quick
> look at your patch shows that it would benefit from the new
> RFKILL_STATE_HARD_BLOCKED, and maybe to some rework to separate the
> bluetooth rfkill controller and the input device switch better. Depending
> on the existence of ACPI GPE events when the switch changes state on
> Toshibas, you may even be able to get rid of some of the polling...
Well, if I can find said GPE, I'll certainly use it. A cursory glance through
the dis-assembled AML didn't reveal anything obvious. Is there a way to log
every single acpi event? I though acpid would receive them but it doesn't
appear to.
> If you rework/repost your patch, please CC Ivo (the rfkill maintainer) and
> the linux-wireless mailing list. If you want me to try to help review the
> patch as well, please also add me to the CC.
>
I'll do this when I next get enough free time. Thanks for the feedback,
--phil
next prev parent reply other threads:[~2008-07-22 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 21:04 [PATCH] toshiba_acpi: Add support for bluetooth toggling through rfkill Philip Langdale
2008-07-20 13:52 ` Henrique de Moraes Holschuh
2008-07-22 4:20 ` Philip Langdale [this message]
2008-07-22 11:25 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48855FFB.40808@overt.org \
--to=philipl@overt.org \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=randy.dunlap@oracle.com \
--cc=toshiba_acpi@memebeam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.