From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, David Bremner <bremner@unb.ca>
Subject: Re: git status in clean working dir
Date: Tue, 22 Jul 2008 09:34:45 +0200 [thread overview]
Message-ID: <48858D95.7060409@viscovery.net> (raw)
In-Reply-To: <20080722044157.GA20787@sigill.intra.peff.net>
Jeff King schrieb:
> @@ -231,6 +232,8 @@ static int run_command(struct cmd_struct *p, int argc, const char **argv)
> use_pager = check_pager_config(p->cmd);
> if (use_pager == -1 && p->option & USE_PAGER)
> use_pager = 1;
> + if (use_pager == 1 && p->option & FORBID_PAGER)
> + use_pager = 0;
> commit_pager_choice();
>
> if (p->option & NEED_WORK_TREE)
> @@ -286,7 +289,7 @@ static void handle_internal_command(int argc, const char **argv)
> { "count-objects", cmd_count_objects, RUN_SETUP },
> { "describe", cmd_describe, RUN_SETUP },
> { "diff", cmd_diff },
> - { "diff-files", cmd_diff_files, RUN_SETUP },
> + { "diff-files", cmd_diff_files, RUN_SETUP | FORBID_PAGER },
Every now and then I want to use 'git -p diff-files', and I think that is
a valid use-case. But your suggested patch seems to forbid the pager even
in this case. :-(
-- Hannes
next prev parent reply other threads:[~2008-07-22 7:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 23:13 git status in clean working dir David Bremner
2008-07-22 2:30 ` Junio C Hamano
2008-07-22 2:36 ` Abhijit Menon-Sen
2008-07-22 2:40 ` Junio C Hamano
2008-07-22 2:48 ` Junio C Hamano
2008-07-22 4:44 ` Jeff King
2008-07-22 4:52 ` Jeff King
2008-07-22 11:24 ` Johannes Schindelin
2008-07-22 4:41 ` Jeff King
2008-07-22 5:39 ` Mike Hommey
2008-07-22 6:06 ` Jeff King
2008-07-22 6:18 ` Mike Hommey
2008-07-22 6:46 ` Jeff King
2008-07-22 7:10 ` Jeff King
2008-07-22 7:12 ` [PATCH 1/2] run-command: add pre-exec callback Jeff King
2008-07-22 7:14 ` [PATCH 2/2] spawn pager via run_command interface Jeff King
2008-07-22 7:16 ` Jeff King
2008-07-22 7:31 ` Pierre Habouzit
2008-07-22 7:49 ` Jeff King
2008-07-22 7:48 ` Johannes Sixt
2008-07-22 7:50 ` Jeff King
2008-07-22 8:29 ` Johannes Sixt
2008-07-22 9:17 ` git status in clean working dir Junio C Hamano
2008-07-22 9:40 ` Jeff King
2008-07-22 14:10 ` David Bremner
2008-07-22 7:34 ` Johannes Sixt [this message]
2008-07-22 7:46 ` Jeff King
2008-07-22 7:54 ` Johannes Sixt
2008-07-24 6:56 ` Ask Bjørn Hansen
2008-07-24 16:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48858D95.7060409@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=bremner@unb.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.