From: Nishanth Menon <menon.nishanth@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch 3/3] U-Boot-V2:Board:OMAP Introduce Beagle
Date: Tue, 22 Jul 2008 06:39:06 -0500 [thread overview]
Message-ID: <4885C6DA.7020707@gmail.com> (raw)
In-Reply-To: <20080722074254.GB7169@pengutronix.de>
Sascha Hauer said the following on 07/22/2008 02:42 AM:
> On Mon, Jul 21, 2008 at 07:19:06PM -0500, Khandenahally, Raghavendra wrote:
>
> This function is unnecessarely big. The two arguments of MUX_VAL could
> go together in one 32bit value. This way you could do a loop around an
> array of mux values. Of course a struct type could do the same thing,
> but having them in one 32bit value allows you to define speaking names
> for the pin configs making it easier for future board developers. See
> include/asm-arm/arch-imx/imx27-regs.h for an example for what I mean.
> This is just an idea, I won't reject the patch because of this.
>
>
Yes, it is obvious that a loop will look simpler, except that the code
context here is in board_init - where only the bare minimum sram stack
is available and cinit is not done.. inline code is a requirement here.
Regards,
Nishanth Menon
next prev parent reply other threads:[~2008-07-22 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 0:19 [U-Boot-Users] [Patch 3/3] U-Boot-V2:Board:OMAP Introduce Beagle Khandenahally, Raghavendra
2008-07-22 7:42 ` Sascha Hauer
2008-07-22 11:39 ` Nishanth Menon [this message]
2008-07-24 22:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4885C6DA.7020707@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.