From: Jeff Garzik <jgarzik@pobox.com>
To: frank.blaschka@de.ibm.com
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
bunk@kernel.org, kaber@trash.net
Subject: Re: [patch 1/1] qeth: fix build error caused by VLAN changes
Date: Tue, 22 Jul 2008 16:09:42 -0400 [thread overview]
Message-ID: <48863E86.90204@pobox.com> (raw)
In-Reply-To: <20080722074014.988096000@de.ibm.com>
frank.blaschka@de.ibm.com wrote:
> Adrian Bunk reports this build error:
>
> CC drivers/s390/net/qeth_l3_main.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/s390/net/qeth_l3_main.c:
> In function 'qeth_l3_hard_start_xmit':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/s390/net/qeth_l3_main.c:
> 2654: error: implicit declaration of function 'VLAN_TX_SKB_CB'
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/s390/net/qeth_l3_main.c:
> 2654: error: invalid type argument of '->' (have 'int')
> make[3]: *** [drivers/s390/net/qeth_l3_main.o] Error 1
>
> The intention of the driver appears to be to invalidate the VLAN tag.
> Change it to set skb->vlan_tci to zero, which has the same effect.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
> ---
> drivers/s390/net/qeth_l3_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
prev parent reply other threads:[~2008-07-22 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 7:39 [patch 0/1] [RESEND] s390: qeth build fix for 2.6.27 frank.blaschka
2008-07-22 7:39 ` [patch 1/1] qeth: fix build error caused by VLAN changes frank.blaschka
2008-07-22 20:09 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48863E86.90204@pobox.com \
--to=jgarzik@pobox.com \
--cc=bunk@kernel.org \
--cc=frank.blaschka@de.ibm.com \
--cc=kaber@trash.net \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.