From: Jeff Garzik <jgarzik@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com
Subject: Re: [PATCH 3/4] sfc: resolve tx multiqueue bug
Date: Tue, 22 Jul 2008 17:29:59 -0400 [thread overview]
Message-ID: <48865157.20709@pobox.com> (raw)
In-Reply-To: <20080722.140023.127726788.davem@davemloft.net>
David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Tue, 22 Jul 2008 19:41:19 +0100
>
>> So long as a queue is only woken in response to TX completions, the current
>> arrangement is fine. However, sfc needs to tear down and restart hardware TX
>> queues as part of some reconfiguration, self-test and recovery code, and I
>> doubt it's the only such driver.
>
> Mark the carrier off and packets will stop flowing to the driver.
Yep.
Though based on looking at a lot of existing driver code, I think this
is sometimes unclear to driver writers -- when to manage carrier
(netif_carrier_on/off) and when to manage queue flow
(netif_queue_start/stop/wake).
Jeff
next prev parent reply other threads:[~2008-07-22 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 17:59 [PATCH 1/4] sfc: I2C adapter initialisation fixes Ben Hutchings
2008-07-18 18:01 ` [PATCH 2/4] sfc: Use a separate workqueue for resets Ben Hutchings
2008-07-18 18:01 ` [PATCH 3/4] sfc: resolve tx multiqueue bug Ben Hutchings
2008-07-18 18:49 ` Ben Hutchings
2008-07-22 18:41 ` Ben Hutchings
2008-07-22 21:00 ` David Miller
2008-07-22 21:29 ` Jeff Garzik [this message]
2008-07-22 21:33 ` David Miller
2008-07-18 18:03 ` [PATCH 4/4] sfc: Create one RX queue and interrupt per CPU package by default Ben Hutchings
2008-07-22 23:44 ` [PATCH 1/4] sfc: I2C adapter initialisation fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48865157.20709@pobox.com \
--to=jgarzik@pobox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.