From: Henrik Rydberg <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
robfitz@273k.net, akpm@osdl.org, jikos@jikos.cz, vojtech@suse.cz,
dmonakhov@openvz.org, johannes@sipsolutions.net,
Oliver Neukum <oliver@neukum.org>,
stern@rowland.harvard.edu
Subject: Re: [PATCH] linux-input: bcm5974-0.57: mode-switch to atp_open, cleanup bug fixed
Date: Wed, 23 Jul 2008 00:19:12 +0200 [thread overview]
Message-ID: <48865CE0.3020605@euromail.se> (raw)
In-Reply-To: <20080722093606.ZZRA012@mailhub.coreip.homeip.net>
Dmitry,
thank you so much for your answers! I would like to send you
a non-patch of the updated driver shortly if I may; it will
require more testing before submission, but having your blessing
first should make things turn around faster.
> >
> > 3. From the state (!opened,suspended), calling open gets us to what
> > state?
> >
Depens on the kind of suspend - manual suspend will cause open to
fail. Autosuspend (if driver implements it) should resume the device.
[...]
>> 5. From the state (opened,suspended), calling resume fails. What state
>> are we in?
>>
>
> Screwed up ;) From the driver POV still (opened, suspended) I think.
>
I feel a bit reluctant to implement this particular behavior, since it
will leave the device in a bad state; if resume fails and stays suspended,
the device cannot later be opened according to 3). What if a failed
resume leaves the device in state (!opened,!suspended)? It could then
later be reopened.
Cheers,
Henrik Rydberg
next prev parent reply other threads:[~2008-07-22 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 11:03 [PATCH] linux-input: bcm5974-0.57: mode-switch to atp_open, cleanup bug fixed Henrik Rydberg
2008-07-20 5:10 ` Dmitry Torokhov
2008-07-21 12:24 ` Henrik Rydberg
2008-07-21 12:24 ` Henrik Rydberg
2008-07-22 0:55 ` Henrik Rydberg
2008-07-22 13:52 ` Dmitry Torokhov
2008-07-22 22:19 ` Henrik Rydberg [this message]
2008-07-23 11:37 ` Henrik Rydberg
2008-07-23 13:38 ` Alan Stern
2008-07-23 13:38 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48865CE0.3020605@euromail.se \
--to=rydberg@euromail.se \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmonakhov@openvz.org \
--cc=jikos@jikos.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=robfitz@273k.net \
--cc=stern@rowland.harvard.edu \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.