From: Jeff Garzik <jeff@garzik.org>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>, netdev@vger.kernel.org
Subject: Re: Fix typo in meth driver
Date: Tue, 22 Jul 2008 19:39:40 -0400 [thread overview]
Message-ID: <48866FBC.1030008@garzik.org> (raw)
In-Reply-To: <4877CCC2.5050702@linux-foundation.org>
Christoph Lameter wrote:
> An | in an if statement to check a bit? I think this needs to be a &.
> As a result of this typo meth will always operate in promiscuous mode.
>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>
> Index: linux-2.6/drivers/net/meth.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/meth.c 2008-07-11 16:05:00.000000000 -0500
> +++ linux-2.6/drivers/net/meth.c 2008-07-11 16:05:02.000000000 -0500
> @@ -287,7 +287,7 @@
>
> /* Initial mode: 10 | Half-duplex | Accept normal packets */
> priv->mac_ctrl = METH_ACCEPT_MCAST | METH_DEFAULT_IPG;
> - if (dev->flags | IFF_PROMISC)
> + if (dev->flags & IFF_PROMISC)
> priv->mac_ctrl |= METH_PROMISC;
> mace->eth.mac_ctrl = priv->mac_ctrl;
>
applied
prev parent reply other threads:[~2008-07-22 23:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 21:12 Fix typo in meth driver Christoph Lameter
2008-07-22 23:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48866FBC.1030008@garzik.org \
--to=jeff@garzik.org \
--cc=cl@linux-foundation.org \
--cc=kay.sievers@vrfy.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.