All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Krasnyansky <maxk@qualcomm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: David Miller <davem@davemloft.net>,
	rusty@rustcorp.com.au, netdev@vger.kernel.org,
	sjackman@gmail.com, linuxkernel@bristyle.com,
	virtualization@lists.linux-foundation.org,
	borntraeger@de.ibm.com
Subject: Re: [PATCH] tun: Fix/rewrite packet filtering logic
Date: Tue, 22 Jul 2008 21:45:30 -0700	[thread overview]
Message-ID: <4886B76A.6000907@qualcomm.com> (raw)
In-Reply-To: <48867BC3.3070506@garzik.org>



Jeff Garzik wrote:
> David Miller wrote:
>> From: Jeff Garzik <jeff@garzik.org>
>> Date: Tue, 22 Jul 2008 19:41:47 -0400
>>
>>> looks mostly OK, but stuff like the above should be
>>>
>>>     (void __user *) arg
>>>
>>> Did you check this with sparse (Documentation/sparse.txt)?

Ah. No I did not check it with sparse.

>>
>> Jeff, I already added this particular patch to the tree
>> a week or so ago.
> 
> Yeah, later on in my queue were the fixes.

I'm not sure I'm following. What fixes ? Are you talking about fixing sparse
warnings or something else ?

Max




  reply	other threads:[~2008-07-23  4:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12  8:52 [PATCH] tun: Fix/rewrite packet filtering logic Max Krasnyansky
2008-07-15  5:16 ` David Miller
2008-07-15  5:16 ` David Miller
2008-07-15  5:17   ` David Miller
2008-07-15  5:17   ` David Miller
2008-07-22 23:41 ` Jeff Garzik
2008-07-23  0:11   ` David Miller
2008-07-23  0:30     ` Jeff Garzik
2008-07-23  4:45       ` Max Krasnyansky [this message]
2008-07-23  4:52         ` David Miller
2008-07-23  4:52         ` David Miller
2008-07-23  4:45       ` Max Krasnyansky
2008-07-23  0:30     ` Jeff Garzik
2008-07-23  0:11   ` David Miller
2008-07-22 23:41 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4886B76A.6000907@qualcomm.com \
    --to=maxk@qualcomm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linuxkernel@bristyle.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sjackman@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.