Paul Brook wrote: > On Sunday 13 July 2008, Jan Kiszka wrote: >> page_find_alloc, used e.g. for TB allocation, is not safe on 64-bit >> hosts for 32-bit guests. Patch below fixes this by requesting new pages >> only from the guest-reachable address range. > > I'm pretty sure this is wrong. The structures allocated by page_find_alloc do > not need to be accessible by the guest. In fact it's better if they are > outside the guest address space. Bet we have "addr = h2g(p);" in page_find_alloc(), ie. we expect to retrieve a valid guest address (for use with page_set_flag). Something is borken here, but you can surely better tell us what precisely than I'm able to. Jan