Re: [PATCH] skge: resolve tx multiqueue bug

[Wang Chen <wangchen@cn.fujitsu.com>]

Markus Trippelsdorf said the following on 2008-7-23 22:03:
> On Wed, Jul 23, 2008 at 12:18:27PM +0200, Markus Trippelsdorf wrote:
>> On Wed, Jul 23, 2008 at 04:50:13PM +0800, Wang Chen wrote:
>>> Markus Trippelsdorf said the following on 2008-7-23 13:40:
>>>> On Tue, Jul 22, 2008 at 11:54:26AM +0200, Alessandro Guido wrote:
>>>>> Got a WARNING this morning (2.6.26-05752-g93ded9b) and I think it's related.
>>>> Same thing here (latest git):
>>>>
>>>> skge eth1: enabling interface
>>>> skge eth1: disabling interface
>>>> ------------[ cut here ]------------
>>>> WARNING: at net/core/dev.c:1344 __netif_schedule+0x24/0x6d()
>>>> Pid: 1904, comm: ip Not tainted 2.6.26-06077-gc010b2f #33
>>>>  [<ffffffff8020b3eb>] system_call_after_swapgs+0x7b/0x80
>> ...
>>>> ---[ end trace 92936ef183e09876 ]---
>>>> skge eth1: enabling interface
>>>> skge eth1: Link is up at 100 Mbps, full duplex, flow control both
>>>>
>>> Markus, please try this.
>>>
>>> - Add netif_start_queue() in ->open()
>>> - netif_carrier_*() is enough, remove netif_*_queue()
>> Unfortunately, your patch does not fix this. I still get the same warning.
>>
> 
> This patch works for me:

Your patch works for me too. So I think it's better than mine. :)

Tested-by: Wang Chen <wangchen@cn.fujitsu.com>

Dave, since Markus and me tested this patch, would you please apply it?