From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: Conntrack Events Performance - Multipart Messages? Date: Wed, 23 Jul 2008 19:40:51 +0200 Message-ID: <48876D23.2080200@trash.net> References: <487E24FC.60700@gmx.ch> <487F18DA.7030208@netfilter.org> <487FFBEE.90409@trash.net> <4884B068.4050306@gmx.ch> <4884B270.5010104@trash.net> <4884CC17.3020905@gmx.ch> <488740E7.3040005@gmx.ch> <48874272.1020503@trash.net> <48875887.8040209@gmx.ch> <488763F3.5020506@trash.net> <4887656B.1090504@trash.net> <48876AAA.9020609@gmx.ch> <48876B48.4060605@trash.net> <48876C96.2070405@gmx.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso To: Fabian Hugelshofer Return-path: Received: from stinky.trash.net ([213.144.137.162]:40963 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbYGWRky (ORCPT ); Wed, 23 Jul 2008 13:40:54 -0400 In-Reply-To: <48876C96.2070405@gmx.ch> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Fabian Hugelshofer wrote: > Patrick McHardy wrote: >> Fabian Hugelshofer wrote: >>> Why do you think the padding causes problems? For hashing e.g. >>> src/dst .u3 and .u are referenced independently of potential padding. >>> Where does access to the padding data occur? >> >> The hash function hashes the entire tuple in one go. >> The padding needs to have deterministic content for >> that. > > Ok, I see. This has been changed since 2.6.24. Makes sense... Indeed. That part might also help speed things up for you a bit. But that would also need this fix: commit 443a70d50bdc212e1292778e264ce3d0a85b896f Author: Philip Craig Date: Tue Apr 29 03:35:10 2008 -0700 netfilter: nf_conntrack: padding breaks conntrack hash on ARM