From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Date: Thu, 24 Jul 2008 07:44:19 +0000 Subject: Re: [PATCH 1/6] kvmppc: read device tree hypervisor node infrastructure Message-Id: <488832D3.8060305@linux.vnet.ibm.com> List-Id: References: <1216802207-32675-1-git-send-email-ehrhardt@linux.vnet.ibm.com> <1216802207-32675-2-git-send-email-ehrhardt@linux.vnet.ibm.com> <20080724014133.GH20457@bakeyournoodle.com> In-Reply-To: <20080724014133.GH20457@bakeyournoodle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="macroman" Content-Transfer-Encoding: base64 To: Tony Breeds Cc: linuxppc-dev@ozlabs.org, hollisb@us.ibm.com, kvm-ppc@vger.kernel.org VG9ueSBCcmVlZHMgd3JvdGU6Cj4gT24gV2VkLCBKdWwgMjMsIDIwMDggYXQgMTA6MzY6NDJBTSAr MDIwMCwgZWhyaGFyZHRAbGludXgudm5ldC5pYm0uY29tIHdyb3RlOgo+Cj4gSGkgQ2hyaXN0aWFu LAo+IAlBIGZldyBjb21tZW50cyBpbmxpbmVkIC4uLgo+Cj4gICAKWy4uLl0KPj4gKwo+PiAgc3Rh dGljIGlubGluZSBpbnQga3ZtX3BhcmFfYXZhaWxhYmxlKHZvaWQpCj4+ICB7Cj4+IC0JcmV0dXJu IDA7Cj4+ICsJc3RydWN0IGRldmljZV9ub2RlICpkbjsKPj4gKwo+PiArCWRuID0gb2ZfZmluZF9u b2RlX2J5X3BhdGgoIi9oeXBlcnZpc29yIik7Cj4+ICAgICAKPgo+IFlvdSBuZWVkIGFuIG9mX25v ZGVfcHV0KGRuKTsKPgo+ICAgCkkganVzdCBsb29rZWQgYXQgdGhlIGxpbnV4L29mLmggYW5kIGRp ZCBub3Qgc2VlIHRoYXQgSSBoYXZlIHRvIGZyZWUgaXQgCmFnYWluLgpUaGFua3MgZm9yIHRoZSBo aW50LCBJIGluc2VydGVkIGJvdGggY2FsbHMuCj4+ICsKPj4gKwlyZXR1cm4gISFkbjsKPj4gIH0K Pj4gIAo+PiAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQga3ZtX2FyY2hfcGFyYV9mZWF0dXJl cyh2b2lkKQo+PiAgewo+PiAtCXJldHVybiAwOwo+PiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqZG47 Cj4+ICsJY29uc3QgaW50ICpkdHZhbDsKPj4gKwl1bnNpZ25lZCBpbnQgZmVhdHVyZXMgPSAwOwo+ PiArCWludCBpOwo+PiArCj4+ICsJZG4gPSBvZl9maW5kX25vZGVfYnlfcGF0aCgiL2h5cGVydmlz b3IiKTsKPj4gKwlpZiAoIWRuKQo+PiArCQlyZXR1cm4gMDsKPj4gKwo+PiArCWZvciAoaSA9IDA7 IGkgPCBBUlJBWV9TSVpFKHBhcmFfZmVhdHVyZXMpLTE7IGkrKykgewo+PiAgICAgCj4KPiBXaHkg LTE/ICBJc24ndCBBUlJBWV9TSVpFKHBhcmFfZmVhdHVyZXMpIGFkZXF1YXRlPwo+ICAgCgp5ZWFo IEkgYWxyZWFkeSBoYWQgdGhpcywgYml0IHRoZSBjaGFuZ2Ugd2FzIGZvbGRlZCBpbnRvIHRoZSB3 cm9uZyBwYXRjaCwgCmZpeGVkIG5vdwoKWy4uLl0KPiBZb3VycyBUb255Cj4KPiAgIGxpbnV4LmNv bmYuYXUgICAgaHR0cDovL3d3dy5tYXJjaHNvdXRoLm9yZy8KPiAgIEphbiAxOSAtIDI0IDIwMDkg VGhlIEF1c3RyYWxpYW4gTGludXggVGVjaG5pY2FsIENvbmZlcmVuY2UhCj4KPiAgIAoKCi0tIAoK R3LDvHNzZSAvIHJlZ2FyZHMsIApDaHJpc3RpYW4gRWhyaGFyZHQKSUJNIExpbnV4IFRlY2hub2xv Z3kgQ2VudGVyLCBPcGVuIFZpcnR1YWxpemF0aW9uCgotLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRo aXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUga3ZtLXBwYyIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtagate8.de.ibm.com (mtagate8.de.ibm.com [195.212.29.157]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mtagate8.de.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 029C0DDED1 for ; Thu, 24 Jul 2008 17:45:22 +1000 (EST) Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m6O7iP5D184944 for ; Thu, 24 Jul 2008 07:44:25 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m6O7iPZF3084336 for ; Thu, 24 Jul 2008 09:44:25 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6O7iOYs025267 for ; Thu, 24 Jul 2008 09:44:25 +0200 Message-ID: <488832D3.8060305@linux.vnet.ibm.com> Date: Thu, 24 Jul 2008 09:44:19 +0200 From: Christian Ehrhardt MIME-Version: 1.0 To: Tony Breeds Subject: Re: [PATCH 1/6] kvmppc: read device tree hypervisor node infrastructure References: <1216802207-32675-1-git-send-email-ehrhardt@linux.vnet.ibm.com> <1216802207-32675-2-git-send-email-ehrhardt@linux.vnet.ibm.com> <20080724014133.GH20457@bakeyournoodle.com> In-Reply-To: <20080724014133.GH20457@bakeyournoodle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linuxppc-dev@ozlabs.org, hollisb@us.ibm.com, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Tony Breeds wrote: > On Wed, Jul 23, 2008 at 10:36:42AM +0200, ehrhardt@linux.vnet.ibm.com wrote: > > Hi Christian, > A few comments inlined ... > > [...] >> + >> static inline int kvm_para_available(void) >> { >> - return 0; >> + struct device_node *dn; >> + >> + dn = of_find_node_by_path("/hypervisor"); >> > > You need an of_node_put(dn); > > I just looked at the linux/of.h and did not see that I have to free it again. Thanks for the hint, I inserted both calls. >> + >> + return !!dn; >> } >> >> static inline unsigned int kvm_arch_para_features(void) >> { >> - return 0; >> + struct device_node *dn; >> + const int *dtval; >> + unsigned int features = 0; >> + int i; >> + >> + dn = of_find_node_by_path("/hypervisor"); >> + if (!dn) >> + return 0; >> + >> + for (i = 0; i < ARRAY_SIZE(para_features)-1; i++) { >> > > Why -1? Isn't ARRAY_SIZE(para_features) adequate? > yeah I already had this, bit the change was folded into the wrong patch, fixed now [...] > Yours Tony > > linux.conf.au http://www.marchsouth.org/ > Jan 19 - 24 2009 The Australian Linux Technical Conference! > > -- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization