From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Guyader Subject: Re: Re: [PATCH] ioemu-remote: ACPI S3 state wake up Date: Thu, 24 Jul 2008 11:48:40 +0100 Message-ID: <48885E08.4050603@eu.citrix.com> References: <48876F9E.8020305@eu.citrix.com> <18567.29232.933108.405959@mariner.uk.xensource.com> <515922b50807240323k99474dfnb679c40290a8aa11@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <515922b50807240323k99474dfnb679c40290a8aa11@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Trolle Selander Cc: xen-devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org I already tried to reduce the rw area, and just keep 0xe0 -> 0xef. But obviously it doesn't work the device model needs to write on this frame 0xf1. I still don't figure out why. Trolle Selander wrote: > Don't leave the main rombios unprotected. I also added a comment to > explain the "magic numbers", since their meaning is perhaps not as > obvious as I thought, in particular now that we're no longer > blanket-protecting the entire firmware area anymore. > > / Trolle > > Signed-off-by: Trolle Selander > > > On Wed, Jul 23, 2008 at 7:02 PM, Ian Jackson > wrote: > > Jean Guyader writes ("[PATCH] ioemu-remote: ACPI S3 state wake up"): > > ioemu-remote: The device model needs to write in the ACPI tables > when it > > wakes up from S3 state. > > I've applied this but I have to say these magic numbers > > - if (xc_hvm_set_mem_type(xc_handle, domid, mem_type, > 0xc0, 0x40)) > > + if (xc_hvm_set_mem_type(xc_handle, domid, mem_type, > 0xc0, 0x20)) > are pretty unpleasant! Are they directly derived from addresses > specified in ACPI ? I haven't looked ... > > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > > -- Jean Guyader