From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: akpm@linux-foundation.org, sct@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
jack@suse.cz, jbacik@redhat.com, cmm@us.ibm.com, tytso@mit.edu,
adilger@clusterfs.com, snitzer@gmail.com, tglx@linutronix.de,
yumiko.sugita.yf@hitachi.com, satoshi.oshima.fk@hitachi.com
Subject: [PATCH 0/4] ext3/jbd: possible filesystem corruption fixes (take 3)
Date: Thu, 24 Jul 2008 21:34:27 +0900 [thread overview]
Message-ID: <488876D3.80004@hitachi.com> (raw)
This patch set is the take 3 of fixing error handling problem in
ext3/JBD. The previous discussion can be found here:
http://kerneltrap.org/mailarchive/linux-kernel/2008/6/2/2002094
Problem
=======
Currently some error checkings are missing, so the journal cannot abort
correctly. This can cause a filesystem corruption. Missing error
checkings are:
(1) error check for the metadata writes to the journal before the
commit (addressed by PATCH 1/4)
(2) error check for checkpointing and replay (addressed by PATCH 2/4
and 3/4)
PATCH 2/4 makes another problem worse; replaying old journaled
metadata can overwrite the latest metadata on the filesystem and
break its consistency. This is fixed by PATCH 4/4.
Changes since Take 2
====================
[PATCH x/x]
o file data error handling fixes were separated to other patch set
[PATCH 3/4]
o fix return value handlings (trivial)
[PATCH 4/4]
o newly added to prevent unjournaled metadata buffers from being
written to the filesystem on abort
Regards,
--
Hidehiro Kawai
Hitachi, Systems Development Laboratory
Linux Technology Center
next reply other threads:[~2008-07-24 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 12:34 Hidehiro Kawai [this message]
2008-07-24 12:37 ` [PATCH 1/4] jbd: abort when failed to log metadata buffers Hidehiro Kawai
2008-09-11 17:41 ` Eric Sandeen
2008-09-11 18:32 ` Eric Sandeen
2008-07-24 12:38 ` [PATCH 2/4] jbd: fix error handling for checkpoint io Hidehiro Kawai
2008-07-24 12:40 ` [PATCH 3/4] ext3: abort ext3 if the journal has aborted Hidehiro Kawai
2008-07-28 6:26 ` Hidehiro Kawai
2008-07-24 12:41 ` [PATCH 4/4] jbd: don't dirty original metadata buffer on abort Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488876D3.80004@hitachi.com \
--to=hidehiro.kawai.ez@hitachi.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=sct@redhat.com \
--cc=snitzer@gmail.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.