From: "Jan Beulich" <jbeulich@novell.com>
To: Kevin Tian <kevin.tian@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: FW: cpufreq info propagation
Date: Thu, 24 Jul 2008 15:18:03 +0100 [thread overview]
Message-ID: <4888AB3B.76E4.0078.0@novell.com> (raw)
In-Reply-To: <D470B4E54465E3469E2ABBC5AFAC390F024D95DC@pdsmsx412.ccr.corp.intel.com>
>Processor freq info is contained in ACPI Px methods in AML style,
>and thus there's no way for Xen to retrieve them without dom0's help.
>However existing ACPI parse logic is only compiled when CPU_FREQ
>is configured. It'd be mess to copy those code out of CPU_FREQ.
I understand that - an alternative idea was to enable CONFIG_CPU_FREQ
by a (conditional) #define in the relevant core ACPI files. But that
should probably be considered only if getting things to work by tweaking
the core cpufreq code turns out to be no less intrusive.
>Also enable CPU_FREQ in dom0 doesn't mean the control goes to
>dom0. Dom0 only tempts to control when cpufreq driver is loaded,
>and by far the driver is hacked from loading when extcnl is requesting.
>This is a bit hacky, and the cleaner way should move such check
>to generic cpufreq layer since there're so many drivers.
Indeed, if that was done e.g. by making cpufreq_register_driver()
fail in this case, I would feel much safer allowing the CPU_FREQ
options again. But that would imply that all the drivers behave
properly when that registration fails, and while powernow-k8
appears to do so, acpi-cpufreq doesn't seem to - it would (in .26)
at least leak per-CPU data allocated in acpi_cpufreq_early_init().
What I'm still unclear about is the role of the kernel governors when
Xen controls cpufreq.
Jan
next prev parent reply other threads:[~2008-07-24 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 13:34 FW: cpufreq info propagation Tian, Kevin
2008-07-24 14:18 ` Jan Beulich [this message]
2008-07-24 14:32 ` Tian, Kevin
-- strict thread matches above, loose matches on Subject: below --
2008-07-24 4:11 Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4888AB3B.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.