From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KM5jQ-0000rn-MT
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 14:40:04 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KM5jO-0000po-SK
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 14:40:04 -0400
Received: from [199.232.76.173] (port=39961 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KM5jO-0000pW-Dz
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 14:40:02 -0400
Received: from py-out-1112.google.com ([64.233.166.183]:16173)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KM5jM-0003SE-5v
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 14:40:01 -0400
Received: by py-out-1112.google.com with SMTP id p76so2212657pyb.10
	for <qemu-devel@nongnu.org>; Thu, 24 Jul 2008 11:39:57 -0700 (PDT)
Message-ID: <4888CC5C.8080001@codemonkey.ws>
Date: Thu, 24 Jul 2008 13:39:24 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] show register info for all cpus
References: <1216923958-3222-1-git-send-email-gcosta@redhat.com>
In-Reply-To: <1216923958-3222-1-git-send-email-gcosta@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Glauber Costa wrote:
> Currently, we only do a register dump for mon_cpu().
> Modify do_info_registers() in order to show what's
> going on in all of them.
>   

The currently implemented behaviour is to allow the 'cpu' command to 
determine which CPU the various monitor commands operate with (including 
info registers).  This is pretty consistent throughout the monitor.

Do you disagree with this behaviour or were you just not aware of it?  
It's unclear from the description in your patch.

Regards,

Anthony Liguori

> Signed-off-by: Glauber Costa <gcosta@redhat.com>
> ---
>  qemu/monitor.c |   18 +++++++++++-------
>  1 files changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/qemu/monitor.c b/qemu/monitor.c
> index 20dcca6..045eecb 100644
> --- a/qemu/monitor.c
> +++ b/qemu/monitor.c
> @@ -292,16 +292,20 @@ static CPUState *mon_get_cpu(void)
>  static void do_info_registers(void)
>  {
>      CPUState *env;
> -    env = mon_get_cpu();
> -    if (!env)
> -        return;
> +
> +    mon_get_cpu();
> +
> +    for(env = first_cpu; env != NULL; env = env->next_cpu) {
> +        term_printf("CPU: %d\n", env->cpu_index);
>  #ifdef TARGET_I386
> -    cpu_dump_state(env, NULL, monitor_fprintf,
> -                   X86_DUMP_FPU);
> +        cpu_dump_state(env, NULL, monitor_fprintf,
> +                       X86_DUMP_FPU);
>  #else
> -    cpu_dump_state(env, NULL, monitor_fprintf,
> -                   0);
> +        cpu_dump_state(env, NULL, monitor_fprintf,
> +                       0);
>  #endif
> +    }
> +    term_printf("\n");
>  }
>  
>  static void do_info_cpus(void)
>