All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	Lennert Buytenhek <kernel@wantstofly.org>,
	Dave Jones <davej@codemonkey.org.uk>, Paul Jackson <pj@sgi.com>,
	Tony Luck <tony.luck@intel.com>,
	Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Robert Richter <robert.richter@amd.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Sam Creasey <sammy@sammy.net>, Greg Banks <gnb@sgi.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Adrian Bunk <bunk@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andreas Schwab <schwab@suse.de>,
	Johannes Weiner <hannes@saeurebad.de>
Subject: Re: [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map
Date: Thu, 24 Jul 2008 17:37:48 -0700	[thread overview]
Message-ID: <4889205C.9080806@sgi.com> (raw)
In-Reply-To: <4888C232.4090906@sgi.com>

Mike Travis wrote:
> Rusty Russell wrote:
>> On Thursday 24 July 2008 03:18:42 Mike Travis wrote:
>>>     Note that the declaration of cpumask_of_cpu_map[] is initialized
>>>     so that cpumask_of_cpu(0) is defined early.  This assumes that
>>>     cpu 0 is the boot cpu.
>> Hi Mike,
>>
>>    Make this statically initialized please.  That almost guarantees there'll
>> be no problems.  It's a little tricky to do, but possible.  Patch below
>> tested on 32 bit x86 only.
> 
> I thought about it, but it didn't seem to be worth the effort.  One problem
> though, the cpumask bits are such that the LSB of the last word is cpu 0.
> So your initializer sets it up in reverse order.  I'll see if I can't
> figure out how to invert it (very tricky coding btw... ;-)

I thought since the cpumask_scnprintf prints out the bit map with the LSB
being cpu 0 that the bit layout was the same.  Further examination reveals
I was wrong about that.

The updated patchset to follow shortly after a bit more testing...

Thanks,
Mike

  reply	other threads:[~2008-07-25  0:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 17:18 [PATCH 0/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map Mike Travis
2008-07-23 17:18 ` [PATCH 1/1] " Mike Travis
2008-07-24  2:45   ` Rusty Russell
2008-07-24 17:56     ` Mike Travis
2008-07-25  0:37       ` Mike Travis [this message]
2008-07-24 11:46   ` Ingo Molnar
2008-07-24 17:11     ` Mike Travis
2008-07-24 19:12       ` Mike Travis
2008-07-24 12:56   ` Bert Wesarg
2008-07-24 17:15     ` Mike Travis
2008-07-25  0:27       ` Mike Travis
2008-07-25  1:26         ` Paul Jackson
2008-07-30 16:55   ` Dave Jones
2008-07-30 17:11     ` Mike Travis
2008-07-30 18:37       ` Mike Travis
2008-07-30 18:50         ` Dave Jones
2008-07-30 19:25           ` Mike Travis
2008-07-30 19:50             ` Dave Jones
2008-07-30 20:02   ` [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map - build breakage Tim Bird
2008-07-30 21:24     ` Mike Travis
2008-07-30 22:03       ` Tim Bird
2008-07-30 23:48         ` Stephen Rothwell
2008-07-31  0:11           ` Tim Bird

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4889205C.9080806@sgi.com \
    --to=travis@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bunk@kernel.org \
    --cc=cl@linux-foundation.org \
    --cc=davej@codemonkey.org.uk \
    --cc=ebiederm@xmission.com \
    --cc=gnb@sgi.com \
    --cc=hannes@saeurebad.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=kernel@wantstofly.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=pj@sgi.com \
    --cc=robert.richter@amd.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sammy@sammy.net \
    --cc=schwab@suse.de \
    --cc=schwidefsky@de.ibm.com \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.