From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 0/4] Fix check for incorrect or missing sequence mumbers
Date: Fri, 25 Jul 2008 01:40:59 +0000 [thread overview]
Message-ID: <48892F2B.2020202@cn.fujitsu.com> (raw)
In-Reply-To: <488840B1.5070303@cn.fujitsu.com>
Gerrit Renker wrote:
> | This patch fix the incorrect or missing sequence mumbers in ICMP
> | message, add the check for incorrect or missing sequence mumbers in
> | ICMPv6 message.
> |
> | [PATCH 1/4] DCCP: Fix to check the sequence number in ICMP message correctly
> | [PATCH 2/4] DCCP: Add check for sequence number in ICMPv6 message
> | [PATCH 3/4] DCCP: Fix to check missing sequence number for ICMP message correctly
> | [PATCH 4/4] DCCP: Add check for missing sequence number in ICMPv6 message
> |
> |
> Thank you. I will work through these and review. Two comments so far
> * they apply not cleanly (to 2.6.26) -- please check your kernel sources;
> * in patches 3/4 the "if (skb->len < ihlen + 12" can be omitted, since
> __dccp_basic_hdr_len() always returns minimally sizeof(struct dccp_hdr) = 12
> (the header size of 8 seems to stem from an earlier draft version of DCCP)
Agree, I will fix the patch. I think she header size of 8 may be caome
from the tcp code^_^?
next prev parent reply other threads:[~2008-07-25 1:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 8:43 [PATCH 0/4] Fix check for incorrect or missing sequence mumbers in Wei Yongjun
2008-07-24 13:10 ` [PATCH 0/4] Fix check for incorrect or missing sequence Gerrit Renker
2008-07-25 1:40 ` Wei Yongjun [this message]
2008-07-25 7:02 ` [PATCH 0/4] Fix check for incorrect or missing sequence mumbers Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48892F2B.2020202@cn.fujitsu.com \
--to=yjwei@cn.fujitsu.com \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.