From: Olivier Marin <dkr+ml.git@free.fr>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Michele Ballabio <barra_cuda@katamail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 6/9] builtin-init-db.c: use parse_options()
Date: Fri, 25 Jul 2008 17:20:26 +0200 [thread overview]
Message-ID: <4889EF3A.6040605@free.fr> (raw)
In-Reply-To: <alpine.DEB.1.00.0807241801030.8986@racer>
Johannes Schindelin a écrit :
>>
>>> + OPT_BOOLEAN(0, "bare", &bare, "set up a bare repo"),
>> s/set up/setup/
>
> No. "setup" is a noun.
Right, sorry.
> We rely on shared_repository == 0 for non-shared repositories _almost
> everywhere_.
I think we rely on the fact that PERM_UMASK == 0 and not on the value
of shared_repository. Not the same thing.
That said, perhaps you are right: it is harmless.
>>> + OPT_BIT('q', "quiet", &flags, "be quiet", INIT_DB_QUIET),
>> OPT__QUIET(&quiet),
>>
>> if (quiet)
>> flags |= INIT_DB_QUIET;
>>
>> to use the same quiet option everywhere?
>
> Why? Doesn't make it more readable, I think. I'd rather have 3 lines
> less.
Hum.
Olivier.
next prev parent reply other threads:[~2008-07-25 15:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 21:42 [PATCH 0/9] Extend use of parse_options() Michele Ballabio
2008-07-23 21:42 ` [PATCH 1/9] builtin-verify-tag.c: use parse_options() Michele Ballabio
2008-07-24 16:59 ` Olivier Marin
2008-07-24 17:08 ` Johannes Schindelin
2008-07-25 15:20 ` Olivier Marin
2008-07-26 0:53 ` Johannes Schindelin
2008-07-28 10:48 ` [PATCH] builtin-verify-tag: fix -v option parsing Olivier Marin
2008-07-28 11:06 ` Johannes Schindelin
2008-07-28 11:42 ` Olivier Marin
2008-07-28 12:10 ` Johannes Schindelin
2008-07-23 21:42 ` [PATCH 2/9] builtin-write-tree.c: use parse_options() Michele Ballabio
2008-07-23 21:42 ` [PATCH 3/9] builtin-prune-packed.c: " Michele Ballabio
2008-07-23 21:42 ` [PATCH 4/9] builtin-ls-tree.c: " Michele Ballabio
2008-07-23 21:42 ` [PATCH 5/9] builtin-rev-list.c: " Michele Ballabio
2008-07-23 21:42 ` [PATCH 6/9] builtin-init-db.c: " Michele Ballabio
2008-07-24 16:15 ` Olivier Marin
2008-07-24 17:07 ` Johannes Schindelin
2008-07-25 15:20 ` Olivier Marin [this message]
2008-07-26 0:55 ` Johannes Schindelin
2008-07-24 20:07 ` Michele Ballabio
2008-07-25 8:15 ` [PATCH 6/9 - v2] " Michele Ballabio
2008-07-25 15:20 ` [PATCH 6/9] " Olivier Marin
2008-07-25 19:53 ` [PATCH 6/9 - v3] " Michele Ballabio
2008-07-23 21:42 ` [PATCH 7/9] builtin-checkout-index.c: " Michele Ballabio
2008-07-24 14:44 ` Johannes Schindelin
2008-07-24 20:08 ` Michele Ballabio
2008-07-24 20:35 ` Sverre Rabbelier
2008-07-25 9:01 ` René Scharfe
2008-07-25 16:25 ` [PATCH 7/9 - v2] " Michele Ballabio
2008-07-23 21:42 ` [PATCH 8/9] builtin-fetch-pack.c: " Michele Ballabio
2008-07-23 21:42 ` [PATCH 9/9] builtin-mailinfo.c: " Michele Ballabio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4889EF3A.6040605@free.fr \
--to=dkr+ml.git@free.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=barra_cuda@katamail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.