All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Eli Collins <ecollins@vmware.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: please revert commit 53f1b1433da7eac2607a4a0898a221a4485fd732 (rtc: push the BKL down into the driver ioctl method)
Date: Fri, 25 Jul 2008 22:52:36 -0400	[thread overview]
Message-ID: <488A9174.40303@zytor.com> (raw)
In-Reply-To: <b6a2187b0807251918w2b2b3810h6c90df28a3261c7f@mail.gmail.com>

Jeff Chua wrote:
> On Fri, Jul 25, 2008 at 11:55 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> Jeff Chua wrote:
>>> This commit is breaking vmware-6.0.4. Upon booting linux (guest) on
>>> vmware, the whole vmware environment crashed.
>> Quality hypervisor we have there...
> 
> Well then, lets hope Vmware will do something to fix this and remove
> the init_mm stuff.

Well, let me clarify:

- if userspace crashes the kernel, it is a kernel problem (except for 
abuse of certain specific privileged interfaces, like /dev/mem.)

- if a kernel crashes the hypervisor, it is likewise a hypervisor 
problem, even if it was triggered by a bug in the kernel.

The hypervisor, after all, is supposed to provide isolation.

As far as the kernel is concerned, the hypervisor is hardware.  Now, we 
work around bugs in broken hardware all the time, and *if it is sane*, 
we should do so here too.  However, it is *still* a hypervisor problem, 
and Vmware needs to fix it.

	-hpa


  reply	other threads:[~2008-07-26  2:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 14:26 please revert commit 53f1b1433da7eac2607a4a0898a221a4485fd732 (rtc: push the BKL down into the driver ioctl method) Jeff Chua
2008-07-25 14:48 ` Alan Cox
2008-07-25 15:55 ` H. Peter Anvin
2008-07-26  2:18   ` Jeff Chua
2008-07-26  2:52     ` H. Peter Anvin [this message]
2008-07-29 23:21     ` Eli Collins
2008-07-30  1:19       ` Jeff Chua
2008-07-30  8:32         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488A9174.40303@zytor.com \
    --to=hpa@zytor.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ecollins@vmware.com \
    --cc=jeff.chua.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.