From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Kevin Hickey <khickey@rmicorp.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/1] Initialization of Alchemy boards
Date: Mon, 28 Jul 2008 10:08:42 +0300 [thread overview]
Message-ID: <488D707A.4090800@movial.fi> (raw)
In-Reply-To: <1217002430.10968.30.camel@kh-ubuntu.razamicroelectronics.com>
Kevin Hickey wrote:
> I found this when I updated to version 2.6.26. None of my development
> boards would boot. It appears that a previous update changed some calls
> to simple_strtol to strict_strtol but did not account for the different
> call semantics.
Hi Kevin,
1) you forgot to sign your patch off;
2) please consider using git to generate and submit patches. At least according to my experience, it's much more convenient than any other approach.
3) As I can see, the board-specific code is almost identical for the pb1x00 boards. While at it, would you please try to merge it?
Regards,
Dmitri
>
> Index: arch/mips/au1000/pb1000/init.c
> ===================================================================
> --- arch/mips/au1000/pb1000/init.c
> +++ arch/mips/au1000/pb1000/init.c
> @@ -52,6 +52,6 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/pb1100/init.c
> ===================================================================
> --- arch/mips/au1000/pb1100/init.c
> +++ arch/mips/au1000/pb1100/init.c
> @@ -54,7 +54,7 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
>
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/pb1200/init.c
> ===================================================================
> --- arch/mips/au1000/pb1200/init.c
> +++ arch/mips/au1000/pb1200/init.c
> @@ -53,6 +53,6 @@
> if (!memsize_str)
> memsize = 0x08000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/mtx-1/init.c
> ===================================================================
> --- arch/mips/au1000/mtx-1/init.c
> +++ arch/mips/au1000/mtx-1/init.c
> @@ -55,6 +55,6 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/pb1500/init.c
> ===================================================================
> --- arch/mips/au1000/pb1500/init.c
> +++ arch/mips/au1000/pb1500/init.c
> @@ -53,6 +53,6 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/xxs1500/init.c
> ===================================================================
> --- arch/mips/au1000/xxs1500/init.c
> +++ arch/mips/au1000/xxs1500/init.c
> @@ -53,6 +53,6 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/pb1550/init.c
> ===================================================================
> --- arch/mips/au1000/pb1550/init.c
> +++ arch/mips/au1000/pb1550/init.c
> @@ -53,6 +53,6 @@
> if (!memsize_str)
> memsize = 0x08000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
> Index: arch/mips/au1000/db1x00/init.c
> ===================================================================
> --- arch/mips/au1000/db1x00/init.c
> +++ arch/mips/au1000/db1x00/init.c
> @@ -57,6 +57,6 @@
> if (!memsize_str)
> memsize = 0x04000000;
> else
> - memsize = strict_strtol(memsize_str, 0, NULL);
> + strict_strtol(memsize_str, 0, &memsize);
> add_memory_region(0, memsize, BOOT_MEM_RAM);
> }
>
next prev parent reply other threads:[~2008-07-28 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey
2008-07-28 7:08 ` Dmitri Vorobiev [this message]
2008-07-28 14:07 ` Kevin Hickey
2008-07-28 14:16 ` Dmitri Vorobiev
2008-07-28 11:03 ` Sergei Shtylyov
2008-07-28 18:16 ` Sergei Shtylyov
2008-07-28 14:11 ` Kevin Hickey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488D707A.4090800@movial.fi \
--to=dmitri.vorobiev@movial.fi \
--cc=khickey@rmicorp.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.