* [PATCH 1/1] Initialization of Alchemy boards
@ 2008-07-25 16:13 Kevin Hickey
2008-07-28 7:08 ` Dmitri Vorobiev
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Kevin Hickey @ 2008-07-25 16:13 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
I found this when I updated to version 2.6.26. None of my development
boards would boot. It appears that a previous update changed some calls
to simple_strtol to strict_strtol but did not account for the different
call semantics.
Index: arch/mips/au1000/pb1000/init.c
===================================================================
--- arch/mips/au1000/pb1000/init.c
+++ arch/mips/au1000/pb1000/init.c
@@ -52,6 +52,6 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/pb1100/init.c
===================================================================
--- arch/mips/au1000/pb1100/init.c
+++ arch/mips/au1000/pb1100/init.c
@@ -54,7 +54,7 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/pb1200/init.c
===================================================================
--- arch/mips/au1000/pb1200/init.c
+++ arch/mips/au1000/pb1200/init.c
@@ -53,6 +53,6 @@
if (!memsize_str)
memsize = 0x08000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/mtx-1/init.c
===================================================================
--- arch/mips/au1000/mtx-1/init.c
+++ arch/mips/au1000/mtx-1/init.c
@@ -55,6 +55,6 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/pb1500/init.c
===================================================================
--- arch/mips/au1000/pb1500/init.c
+++ arch/mips/au1000/pb1500/init.c
@@ -53,6 +53,6 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/xxs1500/init.c
===================================================================
--- arch/mips/au1000/xxs1500/init.c
+++ arch/mips/au1000/xxs1500/init.c
@@ -53,6 +53,6 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/pb1550/init.c
===================================================================
--- arch/mips/au1000/pb1550/init.c
+++ arch/mips/au1000/pb1550/init.c
@@ -53,6 +53,6 @@
if (!memsize_str)
memsize = 0x08000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
Index: arch/mips/au1000/db1x00/init.c
===================================================================
--- arch/mips/au1000/db1x00/init.c
+++ arch/mips/au1000/db1x00/init.c
@@ -57,6 +57,6 @@
if (!memsize_str)
memsize = 0x04000000;
else
- memsize = strict_strtol(memsize_str, 0, NULL);
+ strict_strtol(memsize_str, 0, &memsize);
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
--
Kevin Hickey
Alchemy Solutions
RMI Corporation
khickey@RMICorp.com
P: 512.691.8044
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey @ 2008-07-28 7:08 ` Dmitri Vorobiev 2008-07-28 14:07 ` Kevin Hickey 2008-07-28 11:03 ` Sergei Shtylyov 2008-07-28 14:11 ` Kevin Hickey 2 siblings, 1 reply; 7+ messages in thread From: Dmitri Vorobiev @ 2008-07-28 7:08 UTC (permalink / raw) To: Kevin Hickey; +Cc: ralf, linux-mips Kevin Hickey wrote: > I found this when I updated to version 2.6.26. None of my development > boards would boot. It appears that a previous update changed some calls > to simple_strtol to strict_strtol but did not account for the different > call semantics. Hi Kevin, 1) you forgot to sign your patch off; 2) please consider using git to generate and submit patches. At least according to my experience, it's much more convenient than any other approach. 3) As I can see, the board-specific code is almost identical for the pb1x00 boards. While at it, would you please try to merge it? Regards, Dmitri > > Index: arch/mips/au1000/pb1000/init.c > =================================================================== > --- arch/mips/au1000/pb1000/init.c > +++ arch/mips/au1000/pb1000/init.c > @@ -52,6 +52,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1100/init.c > =================================================================== > --- arch/mips/au1000/pb1100/init.c > +++ arch/mips/au1000/pb1100/init.c > @@ -54,7 +54,7 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1200/init.c > =================================================================== > --- arch/mips/au1000/pb1200/init.c > +++ arch/mips/au1000/pb1200/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x08000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/mtx-1/init.c > =================================================================== > --- arch/mips/au1000/mtx-1/init.c > +++ arch/mips/au1000/mtx-1/init.c > @@ -55,6 +55,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1500/init.c > =================================================================== > --- arch/mips/au1000/pb1500/init.c > +++ arch/mips/au1000/pb1500/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/xxs1500/init.c > =================================================================== > --- arch/mips/au1000/xxs1500/init.c > +++ arch/mips/au1000/xxs1500/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/pb1550/init.c > =================================================================== > --- arch/mips/au1000/pb1550/init.c > +++ arch/mips/au1000/pb1550/init.c > @@ -53,6 +53,6 @@ > if (!memsize_str) > memsize = 0x08000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > Index: arch/mips/au1000/db1x00/init.c > =================================================================== > --- arch/mips/au1000/db1x00/init.c > +++ arch/mips/au1000/db1x00/init.c > @@ -57,6 +57,6 @@ > if (!memsize_str) > memsize = 0x04000000; > else > - memsize = strict_strtol(memsize_str, 0, NULL); > + strict_strtol(memsize_str, 0, &memsize); > add_memory_region(0, memsize, BOOT_MEM_RAM); > } > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-28 7:08 ` Dmitri Vorobiev @ 2008-07-28 14:07 ` Kevin Hickey 2008-07-28 14:16 ` Dmitri Vorobiev 0 siblings, 1 reply; 7+ messages in thread From: Kevin Hickey @ 2008-07-28 14:07 UTC (permalink / raw) To: Dmitri Vorobiev; +Cc: ralf, linux-mips Dmitri, On Mon, 2008-07-28 at 10:08 +0300, Dmitri Vorobiev wrote: > Kevin Hickey wrote: > > I found this when I updated to version 2.6.26. None of my development > > boards would boot. It appears that a previous update changed some calls > > to simple_strtol to strict_strtol but did not account for the different > > call semantics. > > Hi Kevin, > > 1) you forgot to sign your patch off; Indeed I did. Is it sufficient to reply to the original post and add a sign-off line? > 2) please consider using git to generate and submit patches. At least according to my experience, it's much more convenient than any other approach. It's starting to look that way to me. I started my work here using SVN because that's what I'm familiar with. I did some reading about git this weekend and I think I'm going to adopt it for future kernel development. > 3) As I can see, the board-specific code is almost identical for the pb1x00 boards. While at it, would you please try to merge it? Yes, but in a future patch. I'd like to get this one accepted ASAP because it prevents 2.6.26+ from booting on any of our development boards. Next, I want to go through all of the db and pb board specific code and see if I can condense any of it. > > Regards, > Dmitri Thanks, Kevin > > > > > Index: arch/mips/au1000/pb1000/init.c > > =================================================================== > > --- arch/mips/au1000/pb1000/init.c > > +++ arch/mips/au1000/pb1000/init.c > > @@ -52,6 +52,6 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/pb1100/init.c > > =================================================================== > > --- arch/mips/au1000/pb1100/init.c > > +++ arch/mips/au1000/pb1100/init.c > > @@ -54,7 +54,7 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/pb1200/init.c > > =================================================================== > > --- arch/mips/au1000/pb1200/init.c > > +++ arch/mips/au1000/pb1200/init.c > > @@ -53,6 +53,6 @@ > > if (!memsize_str) > > memsize = 0x08000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/mtx-1/init.c > > =================================================================== > > --- arch/mips/au1000/mtx-1/init.c > > +++ arch/mips/au1000/mtx-1/init.c > > @@ -55,6 +55,6 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/pb1500/init.c > > =================================================================== > > --- arch/mips/au1000/pb1500/init.c > > +++ arch/mips/au1000/pb1500/init.c > > @@ -53,6 +53,6 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/xxs1500/init.c > > =================================================================== > > --- arch/mips/au1000/xxs1500/init.c > > +++ arch/mips/au1000/xxs1500/init.c > > @@ -53,6 +53,6 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/pb1550/init.c > > =================================================================== > > --- arch/mips/au1000/pb1550/init.c > > +++ arch/mips/au1000/pb1550/init.c > > @@ -53,6 +53,6 @@ > > if (!memsize_str) > > memsize = 0x08000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > Index: arch/mips/au1000/db1x00/init.c > > =================================================================== > > --- arch/mips/au1000/db1x00/init.c > > +++ arch/mips/au1000/db1x00/init.c > > @@ -57,6 +57,6 @@ > > if (!memsize_str) > > memsize = 0x04000000; > > else > > - memsize = strict_strtol(memsize_str, 0, NULL); > > + strict_strtol(memsize_str, 0, &memsize); > > add_memory_region(0, memsize, BOOT_MEM_RAM); > > } > > > -- Kevin Hickey Alchemy Solutions RMI Corporation khickey@RMICorp.com P: 512.691.8044 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-28 14:07 ` Kevin Hickey @ 2008-07-28 14:16 ` Dmitri Vorobiev 0 siblings, 0 replies; 7+ messages in thread From: Dmitri Vorobiev @ 2008-07-28 14:16 UTC (permalink / raw) To: Kevin Hickey; +Cc: ralf, linux-mips Kevin Hickey wrote: > Dmitri, > > On Mon, 2008-07-28 at 10:08 +0300, Dmitri Vorobiev wrote: >> Kevin Hickey wrote: >>> I found this when I updated to version 2.6.26. None of my development >>> boards would boot. It appears that a previous update changed some calls >>> to simple_strtol to strict_strtol but did not account for the different >>> call semantics. >> Hi Kevin, >> >> 1) you forgot to sign your patch off; > Indeed I did. Is it sufficient to reply to the original post and add a > sign-off line? Well, I think it would be better to recreate the diff. What you have now does not apply: dvorobye@sd048:/work/zoo/src/linux-2.6$ git apply [pasted the patch] error: mips/au1000/pb1000/init.c: No such file or directory error: mips/au1000/pb1100/init.c: No such file or directory error: mips/au1000/pb1200/init.c: No such file or directory error: mips/au1000/mtx-1/init.c: No such file or directory error: mips/au1000/pb1500/init.c: No such file or directory error: mips/au1000/xxs1500/init.c: No such file or directory error: mips/au1000/pb1550/init.c: No such file or directory error: mips/au1000/db1x00/init.c: No such file or directory dvorobye@sd048:/work/zoo/src/linux-2.6$ For a quick intro to creating the kernel patches, please see Documentation/SubmittingPatches, which describes the gitless approach. However, as I mentioned earlier, using git is much better. Thanks, Dmitri ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey 2008-07-28 7:08 ` Dmitri Vorobiev @ 2008-07-28 11:03 ` Sergei Shtylyov 2008-07-28 18:16 ` Sergei Shtylyov 2008-07-28 14:11 ` Kevin Hickey 2 siblings, 1 reply; 7+ messages in thread From: Sergei Shtylyov @ 2008-07-28 11:03 UTC (permalink / raw) To: Kevin Hickey; +Cc: ralf, linux-mips Hello. Kevin Hickey wrote: > I found this when I updated to version 2.6.26. None of my development > boards would boot. It appears that a previous update changed some calls > to simple_strtol to strict_strtol but did not account for the different > call semantics. Oops, that was me who changed/overlooked that, sorry. :-< The patch is fine but you forgot to sign it off. WBR, Sergei ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-28 11:03 ` Sergei Shtylyov @ 2008-07-28 18:16 ` Sergei Shtylyov 0 siblings, 0 replies; 7+ messages in thread From: Sergei Shtylyov @ 2008-07-28 18:16 UTC (permalink / raw) To: Kevin Hickey; +Cc: ralf, linux-mips Hello, I wrote: > The patch is fine but you forgot to sign it off. Oops, it wasn't fine, not applicable with default 'patch -p1' -- as others have noticed. It would also have been good if you gave it a more specific name rather than "Initialization of Alchemy boards". WBR, Sergei ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] Initialization of Alchemy boards 2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey 2008-07-28 7:08 ` Dmitri Vorobiev 2008-07-28 11:03 ` Sergei Shtylyov @ 2008-07-28 14:11 ` Kevin Hickey 2 siblings, 0 replies; 7+ messages in thread From: Kevin Hickey @ 2008-07-28 14:11 UTC (permalink / raw) To: ralf; +Cc: linux-mips I found this when I updated to version 2.6.26. None of my development boards would boot. It appears that a previous update changed some calls to simple_strtol to strict_strtol but did not account for the different call semantics. Signed-off-by: Kevin Hickey <khickey@rmicorp.com> Index: arch/mips/au1000/pb1000/init.c =================================================================== --- arch/mips/au1000/pb1000/init.c +++ arch/mips/au1000/pb1000/init.c @@ -52,6 +52,6 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/pb1100/init.c =================================================================== --- arch/mips/au1000/pb1100/init.c +++ arch/mips/au1000/pb1100/init.c @@ -54,7 +54,7 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/pb1200/init.c =================================================================== --- arch/mips/au1000/pb1200/init.c +++ arch/mips/au1000/pb1200/init.c @@ -53,6 +53,6 @@ if (!memsize_str) memsize = 0x08000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/mtx-1/init.c =================================================================== --- arch/mips/au1000/mtx-1/init.c +++ arch/mips/au1000/mtx-1/init.c @@ -55,6 +55,6 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/pb1500/init.c =================================================================== --- arch/mips/au1000/pb1500/init.c +++ arch/mips/au1000/pb1500/init.c @@ -53,6 +53,6 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/xxs1500/init.c =================================================================== --- arch/mips/au1000/xxs1500/init.c +++ arch/mips/au1000/xxs1500/init.c @@ -53,6 +53,6 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/pb1550/init.c =================================================================== --- arch/mips/au1000/pb1550/init.c +++ arch/mips/au1000/pb1550/init.c @@ -53,6 +53,6 @@ if (!memsize_str) memsize = 0x08000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } Index: arch/mips/au1000/db1x00/init.c =================================================================== --- arch/mips/au1000/db1x00/init.c +++ arch/mips/au1000/db1x00/init.c @@ -57,6 +57,6 @@ if (!memsize_str) memsize = 0x04000000; else - memsize = strict_strtol(memsize_str, 0, NULL); + strict_strtol(memsize_str, 0, &memsize); add_memory_region(0, memsize, BOOT_MEM_RAM); } -- Kevin Hickey Alchemy Solutions RMI Corporation khickey@RMICorp.com P: 512.691.8044 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-07-28 18:16 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-07-25 16:13 [PATCH 1/1] Initialization of Alchemy boards Kevin Hickey 2008-07-28 7:08 ` Dmitri Vorobiev 2008-07-28 14:07 ` Kevin Hickey 2008-07-28 14:16 ` Dmitri Vorobiev 2008-07-28 11:03 ` Sergei Shtylyov 2008-07-28 18:16 ` Sergei Shtylyov 2008-07-28 14:11 ` Kevin Hickey
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.