All of lore.kernel.org
 help / color / mirror / Atom feed
From: A Large Angry SCM <gitzilla@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <johannes.sixt@telecom.at>, git@vger.kernel.org
Subject: Re: [PATCH 1/9] Makefile: Do not install a copy of 'git' in $(gitexecdir)
Date: Mon, 28 Jul 2008 06:41:06 -0400	[thread overview]
Message-ID: <488DA242.3000508@gmail.com> (raw)
In-Reply-To: <7vabg2v83o.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> A Large Angry SCM <gitzilla@gmail.com> writes:
> 
>> Johannes Sixt wrote:
>> [...]
>>> diff --git a/Makefile b/Makefile
>>> index 551bde9..cbab4f9 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1335,6 +1335,7 @@ endif
>>>  			'$(DESTDIR_SQ)$(gitexecdir_SQ)/git$X'; \
>>>  	fi
>>>  	$(foreach p,$(BUILT_INS), $(RM) '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$X' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)
>>> +	$(RM) '$(DESTDIR_SQ)$(gitexecdir_SQ)/git$X'
>>>  ifneq (,$X)
>>>  	$(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) git$X)), $(RM) '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p';)
>>>  endif
>> This new action needs to be in a conditional to keep it from removing
>> the ONLY git executable when bindir and execdir are the same dir.
> 
> Heh, I love bug reports that come immediately after I tag the tip of
> 'master' as -rc1.
> 

Well, I'm currently about a week behind on all things git so this is as 
timely as I could make it. ;-)

  parent reply	other threads:[~2008-07-28 10:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21 19:19 [PATCH 0/9] Make gitexecdir relative to $(bindir) on Windows Johannes Sixt
2008-07-21 19:19 ` [PATCH 1/9] Makefile: Do not install a copy of 'git' in $(gitexecdir) Johannes Sixt
2008-07-21 19:19   ` [PATCH 2/9] Makefile: Normalize $(bindir) and $(gitexecdir) before comparing Johannes Sixt
2008-07-21 19:19     ` [PATCH 3/9] Record the command invocation path early Johannes Sixt
2008-07-21 19:19       ` [PATCH 4/9] Fix relative built-in paths to be relative to the command invocation Johannes Sixt
2008-07-21 19:19         ` [PATCH 5/9] Allow the built-in exec path to be relative to the command invocation path Johannes Sixt
2008-07-21 19:19           ` [PATCH 6/9] Allow add_path() to add non-existent directories to the path Johannes Sixt
2008-07-21 19:19             ` [PATCH 7/9] Windows: Make $(gitexecdir) relative Johannes Sixt
2008-07-21 19:19               ` [PATCH 8/9] Windows: Make sure argv[0] has a path Johannes Sixt
2008-07-21 19:19                 ` [PATCH 9/9] Windows: Do not compile git-shell Johannes Sixt
2008-07-21 19:26                   ` [PATCH 10/9] git-gui: git.git now uses $(gitexec_instdir) to point to the exec-path Johannes Sixt
2008-07-25  4:43                   ` [PATCH 9/9] Windows: Do not compile git-shell Steffen Prohaska
2008-07-23 18:31           ` [PATCH 5/9] Allow the built-in exec path to be relative to the command invocation path Junio C Hamano
2008-07-23 19:12             ` [PATCH 5/9 v2] " Johannes Sixt
2008-07-24  4:21               ` Junio C Hamano
2008-07-24 19:24                 ` Johannes Sixt
2008-07-25  4:50                   ` Junio C Hamano
2008-07-25  8:32                     ` Johannes Sixt
2008-07-25  8:38                       ` Johannes Sixt
2008-07-28  6:42                     ` Junio C Hamano
2008-07-21 23:48     ` [PATCH 2/9] Makefile: Normalize $(bindir) and $(gitexecdir) before comparing Johannes Schindelin
2008-07-22  7:25       ` Johannes Sixt
2008-07-28  0:18   ` [PATCH 1/9] Makefile: Do not install a copy of 'git' in $(gitexecdir) A Large Angry SCM
2008-07-28  6:24     ` Junio C Hamano
2008-07-28  6:39       ` Junio C Hamano
2008-07-28 10:43         ` A Large Angry SCM
2008-07-28 23:13         ` A Large Angry SCM
2008-07-28 10:41       ` A Large Angry SCM [this message]
2008-07-21 23:45 ` [PATCH 0/9] Make gitexecdir relative to $(bindir) on Windows Johannes Schindelin
2008-07-22 19:31   ` Johannes Sixt
2008-07-23 18:28     ` Junio C Hamano
2008-07-23 18:49       ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488DA242.3000508@gmail.com \
    --to=gitzilla@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.sixt@telecom.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.