All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
	JosephChan@via.com.tw, jeff@garzik.org,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: + pata_viac-add-flag-for-vx800-and-add-a-function-for-fixing-internal-bugs-for-via-chipsets.patch added to -mm tree
Date: Mon, 28 Jul 2008 22:14:40 +0900	[thread overview]
Message-ID: <488DC640.3070406@kernel.org> (raw)
In-Reply-To: <20080728134847.612106ec@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>> And, likewise, I think
>>
>> 	if (tf->ctl != tf->last_ctl)
>> 		tf->flags |= ATA_TFLAG_DEVICE;
>> 	ata_sff_tf_load(ap, tf);
>>
>> would be better.
> 
> Are we actually guranteed that tf->device is valid in every case where
> ATA_TFLAG_DEVICE is not set ? I don't think we actually are, in which
> case we should cache the last tf->device in the ap->private_data
> structures

Yeap, tf->device is setup during ata_tf_init().

-- 
tejun

      reply	other threads:[~2008-07-28 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  8:14 + pata_viac-add-flag-for-vx800-and-add-a-function-for-fixing-internal-bugs-for-via-chipsets.patch added to -mm tree akpm
2008-07-28 13:02 ` Tejun Heo
2008-07-28 12:48   ` Alan Cox
2008-07-28 13:14     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488DC640.3070406@kernel.org \
    --to=tj@kernel.org \
    --cc=JosephChan@via.com.tw \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.