From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: Conntrack Events Performance - Multipart Messages? Date: Mon, 28 Jul 2008 20:31:39 +0200 Message-ID: <488E108B.4080505@netfilter.org> References: <487E24FC.60700@gmx.ch> <487F18DA.7030208@netfilter.org> <487FFBEE.90409@trash.net> <4884B068.4050306@gmx.ch> <4884B270.5010104@trash.net> <4884CC17.3020905@gmx.ch> <488740E7.3040005@gmx.ch> <48874272.1020503@trash.net> <48875887.8040209@gmx.ch> <488763F3.5020506@trash.net> <48876725.8010404@gmx.ch> <48876876.6010006@trash.net> <1216905683.31465.10.camel@pumper.lan.luxnet.ch> <48899DBE.5080005@netfilter.org> <4889B5BD.5070004@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Patrick McHardy , netfilter-devel@vger.kernel.org To: Fabian Hugelshofer Return-path: Received: from mail.us.es ([193.147.175.20]:58607 "EHLO us.es" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750838AbYG1Sbq (ORCPT ); Mon, 28 Jul 2008 14:31:46 -0400 In-Reply-To: <4889B5BD.5070004@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: Pablo Neira Ayuso wrote: > Pablo Neira Ayuso wrote: >> Or much simpler, just call read_rcu_unlock() before the first >> nla_nest_start() so that this results in much smaller patch: >> >> nlmsg_failure: >> nla_put_failure: >> read_rcu_unlock(); <--- >> nlmsg_trim(skb, b); >> return -1; Sorry, this is wrong. It should be: nla_put_failure: read_rcu_unlock(); nlmsg_failure: nlmsg_trim(skb, b); return -1; -- "Los honestos son inadaptados sociales" -- Les Luthiers