All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow3 - arbitrary metadata
Date: Mon, 28 Jul 2008 15:08:50 -0500	[thread overview]
Message-ID: <488E2752.7030008@codemonkey.ws> (raw)
In-Reply-To: <a38baa500807281256s7aa6c69em344c655145956b24@mail.gmail.com>

Nathaniel McCallum wrote:
> A project I'm working on requires the ability to store arbitrary 
> metadata in the VM disk image.  Thus, here is a patch that implements 
> that as qcow3.  It basically replaces the 
> header.backing_store_{offset|size} with 
> header.metadata_{offset|size}.  Metadata is then defined as NULL-byte 
> separated 'key:value' pairs.  The attached qcow3 then stores the 
> backing file as 'Backing-File:/home/me/backing_file.img' in the 
> metadata section.  I've included two patches.  One is the full patch 
> against the latest SVN (qcow3.patch).  The second patch is just the 
> diff between qcow2.c and qcow3.c so that you can easily see the changes.

Can you provide more information about what the metadata is used for and 
why it's so important for the metadata to be in the image verses in a 
separate file?

There are other possible ways of doing this that are less invasive.  For 
instance, you could have a fake snapshot in the image that just 
contained your key values pairs.

Introducing a whole new format is a pretty big change especially since 
you're duplicating a ton of code.

Regards,

Anthony Liguori

> I've also wondered if it might be possible to backport these changes 
> into qcow2 instead of qcow3.  However, this would break older versions 
> of qemu that claim to support qcow2.
>
> Nathaniel

  reply	other threads:[~2008-07-28 20:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 19:56 [Qemu-devel] [PATCH] qcow3 - arbitrary metadata Nathaniel McCallum
2008-07-28 20:08 ` Anthony Liguori [this message]
2008-07-28 20:24   ` Nathaniel McCallum
2008-07-28 20:36     ` Paul Brook
2008-07-28 20:52       ` Anthony Liguori
2008-07-28 20:50     ` Anthony Liguori
2008-07-28 21:12       ` Nathaniel McCallum
2008-07-28 21:17         ` Anthony Liguori
2008-07-28 21:19           ` Nathaniel McCallum
2008-07-28 21:39             ` Anthony Liguori
2008-07-29  1:49   ` Jamie Lokier
2008-07-29  2:11     ` Jorge Lucángeli Obes
2008-07-29  2:48       ` Nathaniel McCallum
2008-07-29  3:05         ` Jorge Lucángeli Obes
2008-07-29  3:13     ` Anthony Liguori
2008-07-29  6:44       ` Jamie Lokier
2008-07-29 13:38         ` Anthony Liguori
2008-07-29 16:05           ` Jamie Lokier
2008-07-29  8:48     ` Daniel P. Berrange
2008-07-28 23:04 ` Laurent Vivier
2008-07-29  1:25   ` Nathaniel McCallum
2008-07-29  3:06     ` Anthony Liguori
2008-07-29  3:22       ` Nathaniel McCallum
2008-07-29  6:40         ` maht
2008-07-29  6:44           ` maht
2008-07-29  7:48     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488E2752.7030008@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.