All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiger Yang <tiger.yang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2-tools: Add extended attribute support in mkfs.ocfs2
Date: Tue, 29 Jul 2008 13:49:52 +0800	[thread overview]
Message-ID: <488EAF80.1070207@oracle.com> (raw)
In-Reply-To: <20080725093315.GF6317@ca-server1.us.oracle.com>

Joel Becker wrote:

>> +struct ocfs2_xattr_entry {
>> +	__le32	xe_name_hash;
>> +	__le16	xe_name_offset;
>> +	__u8	xe_name_len;
>> +	__u8	xe_type : 7;
>> +	__u8	xe_local : 1;
>> +	__le64	xe_value_size;
>> +};
> 
> 	We removed the bitfields.

Do we really remove the bitfields? We have no space for new u8 in 
xattr_entry.
Mark said we just need change the bottom bit for xe_local.

> 
> 	This got shuffled around for a 64bit checksum field.  Etc.  Can
> you sync up with Tao?
> 
sure. I will sync up those data struct with Tao.

Thanks,
tiger

  reply	other threads:[~2008-07-29  5:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25  7:06 [Ocfs2-devel] [PATCH 1/2] ocfs2-tools: Add extended attribute support in mkfs.ocfs2 Tiger Yang
2008-07-25  7:06 ` [Ocfs2-devel] [PATCH 2/2] ocfs2-tools: Add extended attribute support in fsck.ocfs2 Tiger Yang
2008-07-25  7:52   ` Tao Ma
2008-07-25  8:56     ` Tiger Yang
2008-07-25  9:08       ` Tao Ma
2008-07-25  9:33 ` [Ocfs2-devel] [PATCH 1/2] ocfs2-tools: Add extended attribute support in mkfs.ocfs2 Joel Becker
2008-07-29  5:49   ` Tiger Yang [this message]
2008-07-29  7:09     ` Tao Ma
2008-07-29 22:23     ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488EAF80.1070207@oracle.com \
    --to=tiger.yang@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.