From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Date: Tue, 29 Jul 2008 15:09:18 +0800 Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2-tools: Add extended attribute support in mkfs.ocfs2 In-Reply-To: <488EAF80.1070207@oracle.com> References: <1216969599-9280-1-git-send-email-tiger.yang@oracle.com> <20080725093315.GF6317@ca-server1.us.oracle.com> <488EAF80.1070207@oracle.com> Message-ID: <488EC21E.5090404@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Tiger Yang wrote: > Joel Becker wrote: > >>> +struct ocfs2_xattr_entry { >>> + __le32 xe_name_hash; >>> + __le16 xe_name_offset; >>> + __u8 xe_name_len; >>> + __u8 xe_type : 7; >>> + __u8 xe_local : 1; >>> + __le64 xe_value_size; >>> +}; >> We removed the bitfields. > > Do we really remove the bitfields? We have no space for new u8 in > xattr_entry. > Mark said we just need change the bottom bit for xe_local. Yes, tiger may be right. Here is the original mail link. http://oss.oracle.com/pipermail/ocfs2-devel/2008-July/002489.html FYI. Regards, Tao