From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Date: Tue, 29 Jul 2008 16:06:27 +0300 Message-ID: <488F15D3.60908@qumranet.com> References: <488EBEFC.5040603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Chris Lalancette Return-path: Received: from il.qumranet.com ([212.179.150.194]:14704 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758683AbYG2NG2 (ORCPT ); Tue, 29 Jul 2008 09:06:28 -0400 In-Reply-To: <488EBEFC.5040603@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Chris Lalancette wrote: > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity in the > save file, which matches what i2c_bus_load() expects to pull out of the save > file later. Without this fix in place, KVM live migration fails since the > sender is only sending 1 byte while the receiver is waiting to receive 4 bytes. > > Avi, I don't know when you plan to next rebase KVM to upstream QEMU, but it's > probably a good idea to carry this patch so that live migration works at all. > > I'll merge qemu upstream as soon as I see this go in. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNouN-000663-NQ for qemu-devel@nongnu.org; Tue, 29 Jul 2008 09:06:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNouM-00064X-2S for qemu-devel@nongnu.org; Tue, 29 Jul 2008 09:06:31 -0400 Received: from [199.232.76.173] (port=37039 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNouL-00064P-UQ for qemu-devel@nongnu.org; Tue, 29 Jul 2008 09:06:30 -0400 Received: from il.qumranet.com ([212.179.150.194]:14711) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNouL-0003fi-Hp for qemu-devel@nongnu.org; Tue, 29 Jul 2008 09:06:29 -0400 Message-ID: <488F15D3.60908@qumranet.com> Date: Tue, 29 Jul 2008 16:06:27 +0300 From: Avi Kivity MIME-Version: 1.0 References: <488EBEFC.5040603@redhat.com> In-Reply-To: <488EBEFC.5040603@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH]: Fix i2c_bus_save, which fixes KVM live migration Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Lalancette Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Chris Lalancette wrote: > Attached is a simple patch to make i2c_bus_save() put a 32-bit quantity in the > save file, which matches what i2c_bus_load() expects to pull out of the save > file later. Without this fix in place, KVM live migration fails since the > sender is only sending 1 byte while the receiver is waiting to receive 4 bytes. > > Avi, I don't know when you plan to next rebase KVM to upstream QEMU, but it's > probably a good idea to carry this patch so that live migration works at all. > > I'll merge qemu upstream as soon as I see this go in. -- error compiling committee.c: too many arguments to function