All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kvm <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>,
	Olaf Schnapper <os@de.ibm.com>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm-userspace: fix memslot assignment
Date: Tue, 29 Jul 2008 16:18:49 +0300	[thread overview]
Message-ID: <488F18B9.1010700@qumranet.com> (raw)
In-Reply-To: <200807281855.04681.borntraeger@de.ibm.com>

Christian Borntraeger wrote:
> Am Sonntag, 27. Juli 2008 schrieb Avi Kivity:
>   
>> This is really a no-op, since s390 will nack a KVM_CAP_SET_TSS_ADDR 
>> query.  Of course, the change is an improvement.
>>
>>     
>>> @@ -92,8 +92,11 @@ int get_free_slot(kvm_context_t kvm)
>>>  	if (tss_ext > 0)
>>>  		i = 0;
>>>  	else
>>> +#if !defined(__s390__)
>>>  		i = 1;
>>> -
>>> +#else
>>> +		i = 0;
>>> +#endif
>>>   
>>>       
>> ppc and ia64 also don't care about TSS_ADDR.  Care to make this depend 
>> on x86, rather than on s390?
>>     
>
> Can do. Should ppc and ia64 start with i=1 or i=0, do they need a reserved 
> slot?
>
>   

They all start with 0 AFAIK (kvm also starts with 0, it just wants it to 
be a special slot).

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2008-07-29 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 15:38 [PATCH] kvm-userspace: fix memslot assignment Christian Borntraeger
2008-07-27  8:18 ` Avi Kivity
2008-07-28 16:55   ` Christian Borntraeger
2008-07-29 13:18     ` Avi Kivity [this message]
2008-07-31  8:01       ` Christian Borntraeger
2008-07-31 11:24         ` Avi Kivity
2008-07-31 12:03           ` Izik Eidos
2008-07-31 12:53           ` Christian Borntraeger
2008-07-31 13:00             ` Avi Kivity
2008-07-31 14:57               ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488F18B9.1010700@qumranet.com \
    --to=avi@qumranet.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cotte@de.ibm.com \
    --cc=ehrhardt@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=os@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.