From: Rene Herman <rene.herman@keyaccess.nl>
To: Takashi Iwai <tiwai@suse.de>
Cc: Alsa-devel <alsa-devel@alsa-project.org>,
Krzysztof Helt <krzysztof.h1@poczta.fm>
Subject: Re: [PATCH 10/10] wss_lib: use wss detection code instead of ad1848 one
Date: Tue, 29 Jul 2008 16:37:08 +0200 [thread overview]
Message-ID: <488F2B14.7050704@keyaccess.nl> (raw)
In-Reply-To: <s5hsktsbw3v.wl%tiwai@suse.de>
On 29-07-08 16:31, Takashi Iwai wrote:
>> 2) debug printks
>>
>> For one example here, see:
>>
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/008978.html
>>
>> /snd_wss_debug
>>
>> Bad, bad, triply bad.
>
> This change is actually buggy. Each second printk should have no
> KERN_* prefix. KERN_* prefix is only for the beginning of the line.
See how these formatting "fixes" made me miss that? ;-)
> A more better fix would be to rewrite this to use a loop, BTW.
Rene.
next prev parent reply other threads:[~2008-07-29 14:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 19:51 [PATCH 10/10] wss_lib: use wss detection code instead of ad1848 one Krzysztof Helt
2008-07-20 16:09 ` Rene Herman
2008-07-23 21:28 ` Rene Herman
2008-07-24 5:26 ` Krzysztof Helt
2008-07-24 9:31 ` Rene Herman
2008-07-28 15:37 ` Takashi Iwai
2008-07-28 18:39 ` Rene Herman
2008-07-29 13:02 ` Takashi Iwai
2008-07-29 14:15 ` Rene Herman
2008-07-29 14:31 ` Takashi Iwai
2008-07-29 14:37 ` Rene Herman [this message]
2008-07-29 18:53 ` Krzysztof Helt
2008-07-29 19:00 ` Rene Herman
2008-07-24 17:19 ` Rene Herman
2008-07-24 18:47 ` Krzysztof Helt
2008-07-24 19:30 ` Rene Herman
2008-07-24 20:05 ` Rene Herman
2008-07-24 21:41 ` Krzysztof Helt
2008-07-25 9:59 ` Rene Herman
2008-08-04 1:47 ` Rene Herman
2008-08-04 4:31 ` Krzysztof Helt
-- strict thread matches above, loose matches on Subject: below --
2008-07-25 13:39 krzysztof.h1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488F2B14.7050704@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@poczta.fm \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.