From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNr9J-0002pg-3Q for qemu-devel@nongnu.org; Tue, 29 Jul 2008 11:30:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNr9H-0002p5-J0 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 11:30:04 -0400 Received: from [199.232.76.173] (port=45663 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNr9H-0002p0-CN for qemu-devel@nongnu.org; Tue, 29 Jul 2008 11:30:03 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57603) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNr9H-0004ey-36 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 11:30:03 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6TFU26B023470 for ; Tue, 29 Jul 2008 11:30:02 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6TFTxWJ029794 for ; Tue, 29 Jul 2008 11:30:00 -0400 Received: from zweiblum.travel.kraxel.org (vpn-4-92.str.redhat.com [10.32.4.92]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m6TFTxE7010037 for ; Tue, 29 Jul 2008 11:29:59 -0400 Message-ID: <488F3776.2020907@redhat.com> Date: Tue, 29 Jul 2008 17:29:58 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch] update sys-queue.h References: <488F31CE.3010109@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Andreas F=E4rber wrote: > Hi, >=20 > Am 29.07.2008 um 17:05 schrieb Gerd Hoffmann: >=20 >> This patch updates the list implementation(s) in audio/sys-queue.h by >> grabbing a fresh copy form netbsd and stripping it down a bit. Gives = us >> a few more useful macros for list manipulation and traversal. > [...] >> - got recent copy from netbsd. >> - deleted debug code. >> - deleted some list implementations, left in only the ones which >> qemu already has. >> >> Signed-off-by: Gerd Hoffmann >=20 > If you're replacing the whole file, wouldn't it make sense to move it > out of audio/? Good point. Next problem: Where should it be moved to? Unfortunaly qemu hasn't a dedicated include directory. Should I create one, so we can start cleaning up the current include mess? Or just drop it into the toplevel directory? cheers, Gerd --=20 http://kraxel.fedorapeople.org/xenner/