From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KNrJO-0000K0-Ny
	for mharc-grub-devel@gnu.org; Tue, 29 Jul 2008 11:40:30 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KNrJM-0000Gd-TA
	for grub-devel@gnu.org; Tue, 29 Jul 2008 11:40:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KNrJK-0000Bv-U0
	for grub-devel@gnu.org; Tue, 29 Jul 2008 11:40:28 -0400
Received: from [199.232.76.173] (port=60967 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KNrJK-0000BR-Mq
	for grub-devel@gnu.org; Tue, 29 Jul 2008 11:40:26 -0400
Received: from mailout04.t-online.de ([194.25.134.18]:58884)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Christian.Franke@t-online.de>) id 1KNrJK-0006FM-Bl
	for grub-devel@gnu.org; Tue, 29 Jul 2008 11:40:26 -0400
Received: from fwd27.aul.t-online.de by mailout04.sul.t-online.de with smtp 
	id 1KNrJH-00012H-0B; Tue, 29 Jul 2008 17:40:23 +0200
Received: from [10.3.2.2]
	(rCnBt4ZlohNn9KRO0OTMQ1DqVeChwaC3Pv6cEC-4kWbHtJ5xtN9YeQ0l12mJs4igtU@[217.235.201.206])
	by fwd27.aul.t-online.de
	with esmtp id 1KNrJ7-0hXE4e0; Tue, 29 Jul 2008 17:40:13 +0200
Message-ID: <488F39DE.4020406@t-online.de>
Date: Tue, 29 Jul 2008 17:40:14 +0200
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <4888E3C5.9090707@t-online.de>
	<20080725204016.GD18149@thorin>	<488B1E37.5000101@t-online.de>
	<1217138942.16601.6.camel@ct> <20080727123946.GC11242@thorin>
In-Reply-To: <20080727123946.GC11242@thorin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ID: rCnBt4ZlohNn9KRO0OTMQ1DqVeChwaC3Pv6cEC-4kWbHtJ5xtN9YeQ0l12mJs4igtU
X-TOI-MSGID: 01dde36c-a77e-4864-b413-87bc83652594
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] update-grub for Cygwin
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Jul 2008 15:40:29 -0000

Robert Millan wrote:
> On Sun, Jul 27, 2008 at 02:09:02AM -0400, Pavel Roskin wrote:
>   
>> On Sat, 2008-07-26 at 14:53 +0200, Christian Franke wrote:
>>     
>>> Robert Millan wrote:
>>>       
>>>> On Thu, Jul 24, 2008 at 10:19:17PM +0200, Christian Franke wrote:
>>>>   
>>>>         
>>>>> +  case "`uname 2>/dev/null`" in
>>>>> +    CYGWIN*)
>>>>>     
>>>>>           
>>>> Could this be done at build time instead? (when generating update-grub
>>>> from update-grub.in)
>>>>
>>>>   
>>>>         
>>> Yes, of course. Some alternatives:
>>>       
>> ...
>>
>> I think it's better to have the check at the run time than any of those
>> alternatives.  If we have many OS specific checks, then we can think how
>> to leave the relevant ones.  At this point, it's probably not worth the
>> trouble.
>>     
>
> Ok I don't mind.  It was just a suggestion.
>
>   

For now, I committed the original version with the run time check.

Christian