From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KNsQC-0002W1-23 for mharc-grub-devel@gnu.org; Tue, 29 Jul 2008 12:51:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNsQA-0002Uq-9Y for grub-devel@gnu.org; Tue, 29 Jul 2008 12:51:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNsQ6-0002St-IK for grub-devel@gnu.org; Tue, 29 Jul 2008 12:51:33 -0400 Received: from [199.232.76.173] (port=54005 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNsQ6-0002So-DJ for grub-devel@gnu.org; Tue, 29 Jul 2008 12:51:30 -0400 Received: from mailout01.t-online.de ([194.25.134.80]:50412) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNsQ4-00007o-Pl for grub-devel@gnu.org; Tue, 29 Jul 2008 12:51:29 -0400 Received: from fwd25.aul.t-online.de by mailout01.t-online.de with smtp id 1KNsQ0-0004dx-01; Tue, 29 Jul 2008 18:51:24 +0200 Received: from [10.3.2.2] (G0lxtyZpohKZyOZH0vnm8YeIz4AEPO-WuHQZ7-1v7JjaHMPhF2jfvICkpXOvuLCZxO@[217.235.255.239]) by fwd25.aul.t-online.de with esmtp id 1KNsPo-1nQNhQ0; Tue, 29 Jul 2008 18:51:12 +0200 Message-ID: <488F4A81.7000805@t-online.de> Date: Tue, 29 Jul 2008 18:51:13 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 MIME-Version: 1.0 To: The development of GRUB 2 References: <4883322E.6040606@t-online.de> <20080722215200.GA15825@thorin> <488CEF3B.7080008@t-online.de> In-Reply-To: <488CEF3B.7080008@t-online.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ID: G0lxtyZpohKZyOZH0vnm8YeIz4AEPO-WuHQZ7-1v7JjaHMPhF2jfvICkpXOvuLCZxO X-TOI-MSGID: 9891f865-cb2f-4c40-84d7-2ebc1312bc0b X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] grub-probe -t prefix, fix update-grub_lib for Cygwin X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2008 16:51:34 -0000 Christian Franke wrote: > Robert Millan wrote: >> On Sun, Jul 20, 2008 at 02:40:14PM +0200, Christian Franke wrote: >> >>> The shell function make_system_path_relative_to_its_root() does not >>> work on Cygwin due to path mapping (e.g. /boot/grub/ is actually >>> /cygwin/boot/grub). >>> >>> This patch adds '-t prefix' to grub-probe. It prints result from >>> grub_get_prefix() which is already extended for Cygwin (svn rev 1584). >>> The result is used in make_system_path_relative_to_its_root(). This >>> keeps the platform dependent code in getroot.c. >>> >>> Christian >>> >>> 2008-07-20 Christian Franke >>> >>> * util/grub-probe.c (enum): Add PRINT PREFIX. >>> (probe): Add PRINT_PREFIX, prints result of >>> grub_get_prefix (). >>> (usage): Add `prefix' to `-t' usage text. >>> Add some '\n' to avoid excess long lines. >>> (main): Add check for `-t prefix' option. >>> >> >> This is different than the usual grub-probe usage in that it doesn't >> operate >> on a device. Perhaps it would make sense to add the functionality >> you want in >> a separate utility? >> >> I have an increasing feeling that grub-probe is becoming bloated >> (though I >> admit, this is mostly my fault) >> >> > > Here is a version with works without grub-probe. > Committed, grub-probe not affected. Now Cygwin support should be complete. Christian