Patrick McHardy wrote: >> @@ -1152,17 +1150,7 @@ ctnetlink_create_conntrack(struct nlattr >> #endif >> >> rcu_read_lock(); >> - helper = __nf_ct_helper_find(rtuple); >> - if (helper) { >> - help = nf_ct_helper_ext_add(ct, GFP_KERNEL); >> - if (help == NULL) { >> - rcu_read_unlock(); >> - err = -ENOMEM; >> - goto err; >> - } >> - /* not in hash table yet so not strictly necessary */ >> - rcu_assign_pointer(help->helper, helper); >> - } >> + __nf_ct_set_helper(ct, GFP_KERNEL); > > This one should be checking the return value. Attached a new version. -- "Los honestos son inadaptados sociales" -- Les Luthiers