From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: src: remove dependency on libiptc headers
Date: Wed, 30 Jul 2008 16:08:57 +0200
Message-ID: <489075F9.9040504@trash.net>
References: <alpine.LNX.1.10.0807300839010.6568@fbirervta.pbzchgretzou.qr> <48907080.8020207@trash.net> <alpine.LNX.1.10.0807300951200.30006@fbirervta.pbzchgretzou.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: pablo@netfilter.org,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
To: Jan Engelhardt <jengelh@medozas.de>
Return-path: <netfilter-devel-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:49035 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750887AbYG3OI7 (ORCPT
	<rfc822;netfilter-devel@vger.kernel.org>);
	Wed, 30 Jul 2008 10:08:59 -0400
In-Reply-To: <alpine.LNX.1.10.0807300951200.30006@fbirervta.pbzchgretzou.qr>
Sender: netfilter-devel-owner@vger.kernel.org
List-ID: <netfilter-devel.vger.kernel.org>

Jan Engelhardt wrote:
> On Wednesday 2008-07-30 09:45, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> commit 8219a9d65fe583de06c2ff4e84d1ea299955184b
>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>> Date:   Wed Jul 30 08:36:33 2008 -0400
>>>
>>> src: remove dependency on libiptc headers
>>>
>>> struct xt_rateest_match_info {
>>> -	char			name1[IFNAMSIZ];
>>> -	char			name2[IFNAMSIZ];
>>> +	char			name1[16];
>>> +	char			name2[16];
>> Seems unrelated and I don't want to apply this change.
>> Please remove the IFNAMSIZ changes.
> 
> Then I would have to add linux/if.h everywhere.

Fine with me. Going towards more magic values is never
a good idea :)