From: Steve Haslam <shaslam@lastminute.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Johannes Sixt <johannes.sixt@telecom.at>
Subject: Re: [PATCH] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.
Date: Wed, 30 Jul 2008 19:53:32 +0100 [thread overview]
Message-ID: <4890B8AC.4010106@lastminute.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0807302020300.3486@wbgn129.biozentrum.uni-wuerzburg.de>
Johannes Schindelin wrote:
> Hi,
>
> On Wed, 30 Jul 2008, Steve Haslam wrote:
>
>> I think that once git-upload-pack.c et al get the argv[0] path over to
>> setup_path() then there's nothing more to do; setup_path() already uses
>> argv0_path in its list of paths to try. I'm confused to the reference to
>> PATH, though: we're avoiding the PATH environment variable completely.
>>
>
> There is an issue in setting up the argv0_path when Git is called as "git"
> and resolved via the PATH: argv[0] then is literally "git".
>
> And we need argv0_path for other things than just calling programs:
> relative etc/gitconfig and libexecdir.
>
Ah, I see what you meant. And all setup_path() actually does is add to
the end of PATH. I should have understood before.
OK, I will split the patch up and tidy it.
SRH
prev parent reply other threads:[~2008-07-30 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 11:27 [PATCH] Glean libexec path from argv[0] for git-upload-pack and git-receive-pack Steve Haslam
2008-07-30 14:56 ` Johannes Schindelin
2008-07-30 16:15 ` Steve Haslam
2008-07-30 18:21 ` Johannes Schindelin
2008-07-30 18:53 ` Steve Haslam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4890B8AC.4010106@lastminute.com \
--to=shaslam@lastminute.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.