All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: akpm@linux-foundation.org
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, chunbo.luo@windriver.com
Subject: Re: [patch 1/2] libata-scsi: don't start hotplug work queue if hotplug is disabled
Date: Thu, 31 Jul 2008 07:42:14 +0900	[thread overview]
Message-ID: <4890EE46.10809@kernel.org> (raw)
In-Reply-To: <200807301932.m6UJWcBV012122@imap1.linux-foundation.org>

akpm@linux-foundation.org wrote:
> From: Chunbo Luo <chunbo.luo@windriver.com>
> 
> Previously, queue_delayed_work() was started unconditionally, but if
> ATA_PFLAG_SCSI_HOTPLUG is not set and we do this, the work queue may cause
> multiple messages like this:
> 
> ata3.00: WARNING: ATAPI is not supported with this driver, device ignored.
> 
> So now,it is only started when the hotplug flag is actually set.
> 
> Signed-off-by: Chunbo Luo <chunbo.luo@windriver.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Oops, I forgot to send the alternative patch (verified by Chunbo).  I'm
sending it to Jeff now and cc'ing you.  Please drop this one when the
patch hits -mm.

Thanks.

-- 
tejun

      reply	other threads:[~2008-07-30 22:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 19:32 [patch 1/2] libata-scsi: don't start hotplug work queue if hotplug is disabled akpm
2008-07-30 22:42 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4890EE46.10809@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chunbo.luo@windriver.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.