All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Eli Britstein <elibr@nvidia.com>
Cc: dev@dpdk.org, asafp@nvidia.com, Ori Kam <orika@nvidia.com>,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>
Subject: Re: [PATCH 2/2] app/testpmd: user assigned flow ID to flows
Date: Wed, 22 Feb 2023 17:50:53 +0100	[thread overview]
Message-ID: <4891383.oAaWjsssbx@thomas> (raw)
In-Reply-To: <20230222141139.3233715-2-elibr@nvidia.com>

22/02/2023 15:11, Eli Britstein:
> Currently, testpmd assigns its own IDs, as indices, to created flows.
> Later, the flow index is used as the ID for flow operations (query,
> destroy, dump).
> 
> Allow the user to assign a user-id, to be later used as an alternative
> to the flow index testpmd assigns.
> 
> Example:
> 
> testpmd> flow create 0 ingress user_id 0x1234 pattern eth / end actions
> count / drop / end
> Flow rule #0 created, user-id 0x1234
> 
> testpmd> flow query 0 0x1234 count user_id
> 
> testpmd> flow dump 0 user_id rule 0x1234
> 
> testpmd> flow destroy 0 rule 0x1234 user_id
> Flow rule user_id 0x1234 destroyed
> 
> testpmd> flow destroy 0 rule 0x1234 user_id
> Flow rule #0 destroyed, user-id 0x1234
> 
> Signed-off-by: Eli Britstein <elibr@nvidia.com>

Please Eli, we need explain why adding this feature.
Could you add the justification done in the RFC?
Thank you.



  reply	other threads:[~2023-02-22 16:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 14:11 [PATCH 1/2] app/testpmd: change rule type Eli Britstein
2023-02-22 14:11 ` [PATCH 2/2] app/testpmd: user assigned flow ID to flows Eli Britstein
2023-02-22 16:50   ` Thomas Monjalon [this message]
2023-03-16 14:19   ` [PATCH V2 1/2] app/testpmd: change flow rule type Gregory Etelson
2023-03-16 14:19     ` [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules Gregory Etelson
2023-06-02 20:19       ` Ferruh Yigit
2023-06-30 10:21         ` Ferruh Yigit
2023-07-04  8:25       ` Ori Kam
2023-07-04 14:40         ` Ferruh Yigit
2023-06-02 20:19     ` [PATCH V2 1/2] app/testpmd: change flow rule type Ferruh Yigit
2023-03-01  1:00 ` [PATCH 1/2] app/testpmd: change " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4891383.oAaWjsssbx@thomas \
    --to=thomas@monjalon.net \
    --cc=aman.deep.singh@intel.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=elibr@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.