All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Jan Engelhardt <jengelh@medozas.de>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: src: remove dependency on libiptc headers
Date: Thu, 31 Jul 2008 09:02:41 +0200	[thread overview]
Message-ID: <48916391.8080407@netfilter.org> (raw)
In-Reply-To: <489075F9.9040504@trash.net>

Patrick McHardy wrote:
> Jan Engelhardt wrote:
>> On Wednesday 2008-07-30 09:45, Patrick McHardy wrote:
>>> Jan Engelhardt wrote:
>>>> commit 8219a9d65fe583de06c2ff4e84d1ea299955184b
>>>> Author: Jan Engelhardt <jengelh@medozas.de>
>>>> Date:   Wed Jul 30 08:36:33 2008 -0400
>>>>
>>>> src: remove dependency on libiptc headers
>>>>
>>>> struct xt_rateest_match_info {
>>>> -    char            name1[IFNAMSIZ];
>>>> -    char            name2[IFNAMSIZ];
>>>> +    char            name1[16];
>>>> +    char            name2[16];
>>> Seems unrelated and I don't want to apply this change.
>>> Please remove the IFNAMSIZ changes.
>>
>> Then I would have to add linux/if.h everywhere.
> 
> Fine with me. Going towards more magic values is never
> a good idea :)

Better include net/if.h which is include in a normal development setup
(libc6-dev package in debian).

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

  reply	other threads:[~2008-07-31  7:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 13:19 src: remove dependency on libiptc headers Jan Engelhardt
2008-07-30 13:45 ` Patrick McHardy
2008-07-30 13:51   ` Jan Engelhardt
2008-07-30 14:08     ` Patrick McHardy
2008-07-31  7:02       ` Pablo Neira Ayuso [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-08-01 13:04 Jan Engelhardt
2008-08-02 11:28 ` Pablo Neira Ayuso
2008-08-02 11:52   ` Pablo Neira Ayuso
2008-08-02 16:24     ` Jan Engelhardt
2008-08-04 14:35       ` Pablo Neira Ayuso
2008-08-04 23:44         ` Jan Engelhardt
2008-08-05  6:58           ` Pablo Neira Ayuso
2008-08-06  9:50             ` Patrick McHardy
2008-08-04 10:48 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48916391.8080407@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.