Re: [ULOGD2 PATCH 11/11] Add option to CFLAGS to avoid useless warning.

[Patrick McHardy <kaber@trash.net>]

Pablo Neira Ayuso wrote:
> Eric Leblond wrote:
>> This patch adds the "-Wno-unused-parameter" option to CFLAGS. This suppress
>> gcc warning that can not be fixed due to the usage of generic system like
>> callback where function definition has to be standardized.
>>
>> Signed-off-by: Eric Leblond <eric@inl.fr>
>> ---
>>  configure.in |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure.in b/configure.in
>> index 96cc2d0..8889575 100644
>> --- a/configure.in
>> +++ b/configure.in
>> @@ -30,7 +30,7 @@ dnl Checks for library functions.
>>  AC_FUNC_VPRINTF
>>  AC_CHECK_FUNCS(socket strerror)
>>  
>> -CFLAGS="$CFLAGS -Wall -Wextra"
>> +CFLAGS="$CFLAGS -Wall -Wextra -Wno-unused-parameter"
> 
> Applied from 1 to 10. Thanks Eric.
> 
> With regards to this patch. This warning vanishes is we remove -Wextra.
> 
> We are not using this flag in any other userspace tools and IIRC Patrick
> said that -Wextra did not provide very useful warning. Any comment on this?


It includes some useful warnings, but also some that tend to
produce lots of false positives. We could enable the useful
ones manually, or simply wait and see how much false positives
we'll actually get.