From mboxrd@z Thu Jan 1 00:00:00 1970 From: BVK Chaitanya Subject: Re: On netfront accelerator add/remove watches Date: Thu, 31 Jul 2008 18:14:24 +0530 Message-ID: <4891B3A8.5090202@symantec.com> References: <488E8F39.4020406@symantec.com> <488EFA50.1070708@solarflare.com> <488FF50A.5000404@symantec.com> <1217431049.4282.24.camel@moonstone.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1217431049.4282.24.camel@moonstone.uk.level5networks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kieran Mansley Cc: Xen-devel@lists.xensource.com, Neil Turton List-Id: xen-devel@lists.xenproject.org Kieran Mansley wrote: > On Wed, 2008-07-30 at 10:28 +0530, BVK Chaitanya wrote: >> Under heavy load and very fine suspend-resume cycles, multiple >> suspend_cancel instances can be running simultaneously. > > I'd be very surprised if that was the case, a lot more would go wrong if > suspend_cancel was running more than once simultaneously for the same > domain. > > We think the bug is due to the suspend being called before the frontend > has reached XenbusStateConnected, then suspend_cancel restoring the > watch that wasn't there before, and then the frontend moving to > XenbusStateConnected and trying to set the watch again. > > Here's a patch that should fix that problem. Could you test and see if > it solves the problem you're seeing? I've not been able to check it > myself as I'm unable to get a recent xen-unstable.hg that will build for > one reason or another today. Yeah, i will test with your patch and let you know. -- bvk-chaitanya