From mboxrd@z Thu Jan  1 00:00:00 1970
From: BVK Chaitanya <bayapuneni_chaitanya@symantec.com>
Subject: Re: [PATCH] serialize suspend-resume process
Date: Thu, 31 Jul 2008 18:34:01 +0530
Message-ID: <4891B841.2090901@symantec.com>
References: <C4B76D38.24E93%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C4B76D38.24E93%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> On 31/7/08 12:57, "BVK Chaitanya" <bayapuneni_chaitanya@symantec.com> wrote:
>> If dom0 issues second suspend request before resume is completed a _new_
>> kthread is started and will proceed with xen_suspend in parallel.  I saw
>> this hitting BUG_ON in netfront_accelerator_add_watch.
> 
> That isn't true. xen_suspend() can only be re-entered after it has switched
> the 'shutting_down' variable to SHUTDOWN_INVALID. At this point resume work
> is completed (except perhaps for resuming some PV devices via xenbus, which
> is done asynchronously).
> 

This is the case if suspend is invoked through xenbus interface.

With suspend event channel in place, i see that suspend request doesn't 
go through the shutdown_handler function when suspend is triggered over 
event channel.


regards,
--
bvk-chaitanya